ABI encoding is out of date
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- blockchain
Research direction
Start by locating the library's uses of ethereumjs-abi and its ABI encoding and decoding entry points. Check the ABI_V2 behavior for bytes and string parameters, then evaluate the suggested ethers migration. Done means newer ABI_V2 messages encode and decode correctly, with tests covering those parameter types.
Written by the indexing model from the issue text.
Description
This library is using ethereumjs-abi, which does not support the newer ABI_V2 spec and has been deprecated as a result: https://github.com/ethereumjs/ethereumjs-abi/issues/86
ABI_V2 changed the way bytes and string params are encoded and I know from personal experience that ethereumjs-abi does not decode newer messages properly. I don't know if the encoding side will work or not, but I would suggest considering a move to ethers if this repo is still in development.
- Dominant language
- TypeScript
- Stars
- 584
- Forks
- 230
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MetaMask/eth-sig-util
-
team-wallet-framework
Difficulty 1/5 Under an hour Newbie friendliness 50/100
MetaMask/eth-sig-util#353 ·
-
tsconfig: Disable `strictNullChecks`, enable `strict`Possibly taken @itzKLAUS claimed this 15 days ago. Openteam-wallet-framework
Difficulty 1/5 Under an hour Newbie friendliness 55/100
MetaMask/eth-sig-util#352 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
MetaMask/eth-sig-util#328 ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
MetaMask/eth-sig-util#304 · 4 comments · 4 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
MetaMask/eth-sig-util#303 ·
All issues in MetaMask/eth-sig-util
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
TomerAberbach/profiler-md#733 ·
Maintainers usually reply within 1 day
-
bug priority: medium
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
brentspine/brents-toasts#143 ·
-
🐛 bug 🗺️ DB Models & Ops
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
LibreChat-AI/LibreChat#17214 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Wavvon/Wavvon-clients#136 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
umami-software/umami#4637 ·
Maintainers usually reply within 3 days