tsconfig: Disable `strictNullChecks`, enable `strict`
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 55/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- build-system
Research direction
Start with tsconfig.json and compare its strictness settings with the linked MetaMask module template configuration. Update the configuration to match the requested strict-checking setup, then confirm the resulting TypeScript configuration is valid and the project still type-checks.
Written by the indexing model from the issue text.
Description
In the tsconfig.json in our module template, we have all of the strict options turned on instead of just null checks: https://github.com/MetaMask/metamask-module-template/blob/085b701d9084b45179caef9db1c0b60afa659a78/tsconfig.json#L12. We should do the same thing here.
- Dominant language
- TypeScript
- Stars
- 584
- Forks
- 230
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MetaMask/eth-sig-util
-
team-wallet-framework
Difficulty 1/5 Under an hour Newbie friendliness 50/100
MetaMask/eth-sig-util#353 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
MetaMask/eth-sig-util#328 ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
MetaMask/eth-sig-util#304 · 4 comments · 4 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
MetaMask/eth-sig-util#303 ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 30/100
MetaMask/eth-sig-util#298 · 9 comments ·
All issues in MetaMask/eth-sig-util
Similar issues
-
native
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
prime-radiant-inc/evener#4839 ·
Maintainers usually reply within 1 day
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
processone/fluux-messenger#1790 ·
Maintainers usually reply within 1 day
-
🛣️ Infrastructure
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
opencrvs/opencrvs-core#14232 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
kunchenguid/gh-axi#220 ·
Maintainers usually reply within 1 day