`mergin push` prints "Done" and exits 0 when changes remain beyond MAX_UPLOAD_CHANGES
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 45/100
Research direction
Start with push() in cli.py and the LocalProjectChanges truncation to MAX_UPLOAD_CHANGES, then compare with how sync loops until no changes remain. Reproduce by adding 150 files and checking that status still lists changes after push. The issue leaves open whether push should loop like sync or report the remaining count and exit non-zero, so settle that with the maintainers before coding.
Written by the indexing model from the issue text.
Description
With more than 100 local changes, mergin push uploads one batch, prints Done and exits 0. LocalProjectChanges truncates the batch to MAX_UPLOAD_CHANGES, taking additions first. The changes left over show up only in a later mergin status.
Seen in 0.14.2. push() in cli.py and the limit are unchanged in 0.15.0.
To reproduce
- Add 150 files to a project.
- Run
mergin push. It printsDone. - Run
mergin status. It still lists 50 additions.
A script that checks the exit code reads this as a complete push. We pushed two projects of about 965 changes each, and each push moved exactly 100. Looping push until status was empty finished them, which is what mergin sync does internally.
Could push either keep going like sync, or say how many changes remain and exit non-zero?
- Dominant language
- Python
- Stars
- 24
- Forks
- 12
- Avg merge
- 6d 23h
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MerginMaps/python-api-client
-
VacuumingOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
MerginMaps/python-api-client#320 ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
MerginMaps/python-api-client#270 ·
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
MerginMaps/python-api-client#257 · 3 comments ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 25/100
MerginMaps/python-api-client#254 · 1 comment ·
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
MerginMaps/python-api-client#245 ·
All issues in MerginMaps/python-api-client
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Deltares/numba_celltree#100 · 1 comment ·
-
auto-reported bug
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
Maintainers usually reply within 1 day
-
soup airgap-bundle --bundle-size-cap nan, inf or a cap above ~1.67e299 GiB stops with an internal ValueError/OverflowError (exit 1) instead of a usage errorPossibly taken @Keshemir claimed this today. Openbug claimed difficulty:2
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
MakazhanAlpamys/Soup#3045 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
dagster-io/skills#80 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day