`mergin push` prints "Done" and exits 0 when changes remain beyond MAX_UPLOAD_CHANGES

未關閉
#328 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
半天
新手友好度
45/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
python
領域
cli

研究方向

Start with push() in cli.py and the LocalProjectChanges truncation to MAX_UPLOAD_CHANGES, then compare with how sync loops until no changes remain. Reproduce by adding 150 files and checking that status still lists changes after push. The issue leaves open whether push should loop like sync or report the remaining count and exit non-zero, so settle that with the maintainers before coding.

由索引模型根據 Issue 內容生成。

描述

With more than 100 local changes, mergin push uploads one batch, prints Done and exits 0. LocalProjectChanges truncates the batch to MAX_UPLOAD_CHANGES, taking additions first. The changes left over show up only in a later mergin status.

Seen in 0.14.2. push() in cli.py and the limit are unchanged in 0.15.0.

To reproduce

  1. Add 150 files to a project.
  2. Run mergin push. It prints Done.
  3. Run mergin status. It still lists 50 additions.

A script that checks the exit code reads this as a complete push. We pushed two projects of about 965 changes each, and each push moved exactly 100. Looping push until status was empty finished them, which is what mergin sync does internally.

Could push either keep going like sync, or say how many changes remain and exit non-zero?

主要語言
Python
星號
24
分支
12
平均合併
6 天 23 小時
30 天內合併 PR
3

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

MerginMaps/python-api-client 的其他 Issue

查看 MerginMaps/python-api-client 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。