Use QGIS transaction groups to avoid committing a new parent feature before its children
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
Research direction
Start by reading the issue’s references to MMFormPage.qml, MMFormStackController.qml, attributecontroller.cpp, and multieditmanager.cpp, then trace acquireId(), save, and rollback behavior. Check how the app configures QGIS transaction groups and how its providers handle layers across datasources. Done means a defined, verified approach for atomic save and cancel across supported project setups, including the open questions in the issue.
Written by the indexing model from the issue text.
Description
Context
Found while reviewing #4742 (composition relations and delete).
Creating a child feature for a new, unsaved parent currently works like this:
MMFormPage.qmlcallscontroller.acquireId(), which adds the parent and commits it (AttributeController::acquireId()ends incommit()), so the child can get a real foreign key.- Every form then commits its own layer on save (
AttributeController::save()->commit()). - Discarding a new parent therefore has to delete a parent and children that are already on disk (
MMFormPage.qmlrollbackAndClose()), instead of rolling anything back. - Autosync is paused while forms are open (
MMFormStackController.qml) so a half-created tree is not synced.
Consequences:
- Not atomic across layers: a failure between the parent commit and the child commits leaves a committed parent with missing children.
- If the app is killed mid-form, the early-committed parent stays.
- Discard needs relation-walking delete logic (#4742) instead of one rollback.
How QGIS does it
QGIS has no acquireId step. Its relation editor copies the parent's referenced field value into the child (QgsAbstractRelationEditorWidget::addFeature). The real id for an unsaved parent comes from transaction groups (project setting "automatic transaction groups"):
QgsTransactionGroupopens one provider transaction and starts editing on all layers in the group.- Layers in a transaction use
QgsVectorLayerEditPassthrough(QgsVectorLayer::createEditBuffer()), so edits go straight into the open transaction and the parent insert returns a real id immediately. - The whole group is committed or rolled back together, so cancelling a new parent is a single rollback.
Proposal
Investigate enabling transaction groups for the layers of a project, so that:
acquireId()adds the parent inside the open transaction without committing.- Save commits the group once, cancel rolls it back, and no relation-walking delete is needed on discard.
Open questions (not verified)
- Provider support: transactions need a provider that supports them and all layers on the same datasource. What about projects with layers in several files?
- Passthrough edit mode: there is no edit-buffer undo and failure behaviour differs.
rollBack()/commitChanges()are called per layer in many places (attributecontroller.cpp,multieditmanager.cpp) and need auditing. - A write transaction held open for the duration of a form session on mobile: how does it interact with sync reading the GeoPackage, and what happens if the app is killed?
- Who enables it: the app does not set the transaction mode today (no
TransactionGroupusage inapp,core,test). Is it a project-author setting or something the app forces? - How should the app behave on projects that do not use a transaction group?
Related
- #4742
- Dominant language
- C++
- Stars
- 394
- Forks
- 91
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 16
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MerginMaps/mobile
-
Sign up button opens the Sign in page instead of the Sign up page for Enterprise edition serversOpenauth bug ui/ux
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
MerginMaps/mobile#4795 ·
Maintainers usually reply within 2 days
-
bug ui/ux
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
MerginMaps/mobile#4786 ·
Maintainers usually reply within 2 days
-
bluetooth bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
MerginMaps/mobile#4741 ·
Maintainers usually reply within 2 days
-
bug ui/ux
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
MerginMaps/mobile#4669 ·
Maintainers usually reply within 2 days
-
bug Good first issue ui/ux
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
MerginMaps/mobile#4665 ·
Maintainers usually reply within 2 days
All issues in MerginMaps/mobile
Similar issues
-
Issue-Docs Needs-Triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
microsoft/winget-cli#6692 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
stratum-mining/sv2-tp#167 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
HarperFast/rocksdb-js#1118 ·
Maintainers usually reply within 1 day
-
bug triage
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
26.04 bug dark-mode Easy Hack impress symptom: visual
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
CollaboraOnline/online#16421 · 1 comment ·