Cover commitSync() error precedence through the public Transaction wrapper
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
Research direction
Read #1103 first because it also changes commitSync() shutdown assertions. Then inspect test/fixtures/fork-commit-sync-shutdown.mts and the public Transaction wrapper; add a sync mode that checks commit error precedence during a foreign shutdown. Done when the test fails if shutdown replaces the commit error with “Database not open” and passes for the expected precedence.
Written by the indexing model from the issue text.
Description
Problem
The wrapper-level test for #1100 covers only async Transaction.commit() (test/fixtures/fork-commit-admission-shutdown.mts). commitSync() shares the same error-precedence code, but no test fails if it regresses: a foreign shutdown() during commitSync() would again replace the commit's error with "Database not open".
Possible direction
Add a sync mode through the public Transaction wrapper to test/fixtures/fork-commit-sync-shutdown.mts (it currently tolerates both errors with a regex). Check #1103, which also touches commitSync() shutdown assertions, first.
Review-Deferral: 4306852a8a0513a6 severity=minor category=test-coverage
🤖 Generated by Anthropic Claude (Sonnet 5.5); posted via @cb1kenobi.
- Dominant language
- C++
- Stars
- 24
- Forks
- 3
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 94
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from HarperFast/rocksdb-js
-
CLI crashes with ENOTCONN instead of exiting 0 when stdout closes on macOSPossibly taken @cb1kenobi claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
HarperFast/rocksdb-js#1112 ·
Maintainers usually reply within 1 day
-
A durable commit is reported as failed when aftercommit hits a database closed after the commitOpen
Difficulty 4/5 3-5 days Newbie friendliness 48/100
HarperFast/rocksdb-js#1117 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 4/5 1-2 days Newbie friendliness 38/100
HarperFast/rocksdb-js#1114 ·
Maintainers usually reply within 1 day
-
Release builds abort the process when an internal native assert failsPossibly taken @cb1kenobi claimed this today. Openbug
HarperFast/rocksdb-js#1113 · 1 assignee ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 30/100
HarperFast/rocksdb-js#1111 ·
Maintainers usually reply within 1 day
All issues in HarperFast/rocksdb-js
Similar issues
-
bug triage
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
26.04 bug dark-mode Easy Hack impress symptom: visual
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
CollaboraOnline/online#16421 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
telegramdesktop/tdesktop#31653 ·
Maintainers usually reply within 1 day
-
area/cs bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
ydb-platform/ydb#59881 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day