File/folder renames where only capitalization changes causes assumed duplication
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
Research direction
Start by tracing how the language server tracks an open file when its path changes only in capitalization, using the reproduction steps with a.lua renamed to A.lua on Windows. The report does not name a source file or test, so locate the file tracking and duplicate-field diagnostic entry points, then add a regression test for the rename case. Done when the class fields are no longer reported as duplicates after the rename.
Written by the indexing model from the issue text.
Description
How are you using the lua-language-server?
Visual Studio Code Extension (sumneko.lua)
Which OS are you using?
Windows
What is the issue affecting?
Diagnostics/Syntax Checking
Expected Behaviour
When a file or folder is renamed from, for example, test to Test, the language server should not suddenly mark everything as Duplicate-Defined-Field/etc.
Actual Behaviour
All fields within classes are marked as duplicates.
Reproduction steps
- Create a file,
a.lua. - Open the file so it's an opened tab in the editor.
- Rename it to
A.lua. - Write a basic class definition into it.
---@class X
---@field Y string
local x = {}
function x.new() end
- Observe the bug.
Additional Notes
Windows treats paths containing different capitalization as the same file, unlike linux. a.lua in Windows is the same as A.lua. I believe there is an assumption somewhere that a.lua does not equal A.lua and it causes the language server to bug out.
Log File
I just want to report this then sleep. If nobody else is able to reproduce/get logs, I will do so tomorrow.
- Dominant language
- Lua
- Stars
- 4.4k
- Forks
- 449
- Avg merge
- 15d 6h
- Merged PRs (30d)
- 4
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from LuaLS/lua-language-server
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
LuaLS/lua-language-server#3481 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 87/100
LuaLS/lua-language-server#3480 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
LuaLS/lua-language-server#1776 ·
-
`continue -- comment` rejected with `runtime.nonstandardSymbol=["continue"]`Possibly taken @ybai08 claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
LuaLS/lua-language-server#3474 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
LuaLS/lua-language-server#3470 ·
All issues in LuaLS/lua-language-server
Similar issues
-
bug discord guide:04-the-barrens locale:enUS triage v0.2.6
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
P2: A timed rotation maneuver does nothing on a ship that had an earlier timed lateral maneuverOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
scp-fs2open/fs2open.github.com#7914 ·
Maintainers usually reply within 1 day
-
severity: low
Difficulty 1/5 1-3 hours Newbie friendliness 89/100
luainkernel/lunatik#1980 ·
Maintainers usually reply within 1 day
-
enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gabrielmongefranco/privatium-app-meds#26 ·
Maintainers usually reply within 1 day