`continue -- comment` rejected with `runtime.nonstandardSymbol=["continue"]`
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- lua
- Domain
- testing-qa, tooling
Research direction
Start with the Lua syntax checking and diagnostics paths for parsing continue with a trailing comment; compare them with the reproduction where continue has no comment. Confirm both reported errors are fixed for the commented case while the uncommented case still parses correctly.
Written by the indexing model from the issue text.
Description
How are you using the lua-language-server?
Visual Studio Code Extension (sumneko.lua)
Which OS are you using?
Linux
What is the issue affecting?
Diagnostics/Syntax Checking
Expected Behaviour
The continue should not be underlined in red or error.
for i = 1, 2 do
continue -- trailing comment
end
Actual Behaviour
Two errors:
- Unexpected < exp > . Lua Syntax Check.(exp-in-action)
- Undefined global
continue. Lua Diagnostics.(undefined-global)
Reproduction steps
This parses correctly:
for i = 1, 2 do
continue
end
This does not:
for i = 1, 2 do
continue -- trailing comment
end
Additional Notes
No response
Log File
No response
- Dominant language
- Lua
- Stars
- 4.4k
- Forks
- 449
- Avg merge
- 15d 6h
- Merged PRs (30d)
- 4
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from LuaLS/lua-language-server
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
LuaLS/lua-language-server#3481 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 87/100
LuaLS/lua-language-server#3480 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
LuaLS/lua-language-server#1776 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
LuaLS/lua-language-server#3478 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
LuaLS/lua-language-server#3470 ·
All issues in LuaLS/lua-language-server
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
jangala-dev/devicecode-lua#344 ·
-
Kill Ishamuhale for Ishamuhale's FangPossibly taken A pull request linked to this issue is open or already merged. Openbug discord guide:04-the-barrens locale:enUS triage v0.2.6
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Balatro-Potato-Patch/Wormhole#145 ·
-
P2: A timed rotation maneuver does nothing on a ship that had an earlier timed lateral maneuverOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
scp-fs2open/fs2open.github.com#7914 ·
Maintainers usually reply within 1 day