"Open file" on the validation page fails when Euro-Office/ONLYOFFICE is the default PDF viewer
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 25/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start with src/utils/viewer.js, where the issue says the validation page passes the owner's original nodeId to OCA.Viewer. Check how that ID is used for logged-in users versus logged-out users. Done means everyone opens the signed PDF in the reported setup; linked pull request #9104 indicates work is already underway.
Written by the indexing model from the issue text.
Description
Describe the bug
"Open file" on the validation page fails when Euro-Office/ONLYOFFICE is the default PDF viewer
To reproduce
- Set Euro-Office (or ONLYOFFICE) as the default app for PDF.
- User X sends a file to Nextcloud users Y and Z for signing (file not shared). Both sign.
- Open the validation page and click "Open file":
as X: the unsigned original opens;
as Y, or any other logged-in user: {"error":"File not found"};
logged out: the signed PDF opens correctly.
Expected behavior
everyone sees the signed PDF.
Screenshots
Operational System
NixOS
Browser Type and Version
No response
Libresign Version
15.0.6
Nextcloud Server Version
35.0.0
Logs from Nextcloud Server
Error
eurooffice
Config: 522495 File not found
Logs from Developers tools
No response
Additional context
Cause: for logged-in users, the validation page passes the owner's original nodeId to OCA.Viewer (src/utils/viewer.js)
Euro-Office looks that ID up in the current user's files, so it either fails or shows the original upload
- Dominant language
- PHP
- Stars
- 830
- Forks
- 161
- Avg merge
- 13h 34m
- Merged PRs (30d)
- 493
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from LibreSign/libresign
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
LibreSign/libresign#9007 · 1 reaction ·
Maintainers usually reply within 1 day
-
backend enhancement php
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Validation page says "This document is valid" for a document with no signaturePossibly taken @maia-andre claimed this 15 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LibreSign/libresign#8284 · 5 comments ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Maintainers usually reply within 1 day
All issues in LibreSign/libresign
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
grokability/snipe-it#19869 · 2 comments ·
Maintainers usually reply within 1 day
-
sync-en
Difficulty 1/5 Under an hour Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
sync-en
Difficulty 1/5 Under an hour Newbie friendliness 77/100
Maintainers usually reply within 3 days
-
Перевод устарел
Difficulty 1/5 Under an hour Newbie friendliness 74/100