Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Validation page says "This document is valid" for a document with no signature

Open Beginner friendly
  • Is something wrong?
#8,967 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@maia-andre is already working on this.

Since Oct 4, 2026.

  • #9009 by @maia-andre — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript
Domain
frontend

Research direction

Start in src/views/Validation.vue at getDocumentValidationSummary(), which currently bases the summary on the signer list. Check the unsigned and canceled-document scenarios described in the issue, then verify that documents with no applied signatures show the existing no-signatures message while signed documents retain the current validation checks.

Written by the indexing model from the issue text.

Description

Describe the bug

The validation page shows the green note "This document is valid" for a document that has no signature at all, for example a request that was just sent and nobody has signed yet. It also shows it for a canceled envelope where nobody signed.

getDocumentValidationSummary() in src/views/Validation.vue decides on the list of signers, not on the signatures actually applied:

  • it returns "No digital signatures were found in this document" only when the signers array is empty;
  • otherwise, when no integrity problem is found among the signers, it returns "This document is valid".

A signer who has not signed carries no signature_validation, modification_validation or document_modification_state, so none of the error or warning branches match and the summary falls through to "valid". The same logic is on stable35 and main.

To reproduce
  1. Request a signature on any PDF from one signer.
  2. Before anybody signs, open /apps/libresign/p/validation/<uuid> (logged out or as the requester).
  3. The page says This document is valid, with the status Ready to sign and the signer Not signed yet right below it.
Expected behavior

The summary should be based on the signatures that were actually applied:

  • no signature applied → the existing "No digital signatures were found in this document" (info), whatever the number of signers;
  • at least one signature → the current checks, evaluated on the signed signers only.

The file status (ready to sign, partially signed, canceled) is already shown in the details below the note, so I don't think the note needs to repeat it. Open to a different wording if you prefer one for pending documents.

Screenshots

Unsigned document:

Unsigned document marked as valid

Canceled envelope where nobody signed: the header above this summary also reads "This document is valid".

Envelope where nobody signed

Operational System

Linux (devcontainer)

Browser Type and Version

Chromium (Playwright)

Libresign Version

16.0.0-dev (main); same logic on stable35

Nextcloud Server Version

36 (dev)

Logs from Nextcloud Server

None; this is frontend-only.

Dominant language
PHP
Stars
828
Forks
159
Avg merge
7h 50m
Merged PRs (30d)
515

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from LibreSign/libresign

All issues in LibreSign/libresign

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.