Characterize cancellation notification and sequential-signing consistency
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 42/100
Research direction
Start with tests/integration/features/sign/cancel.feature and sequential_signing.feature; inspect how the existing PHPUnit integration environment persists signing requests and how the Behat scenarios observe notifications. Reproduce the controlled removal failure and the same-order signer flow described in the issue, then run the relevant integration tests. Done means the tests confirm no cancellation notification or false success after failed removal, and that C is activated and notified once only after A signs.
Written by the indexing model from the issue text.
Description
Goal
Verify that cancellation and sequential-signing notifications correspond to successful persisted state changes.
Test approach
Reuse tests/integration/features/sign/cancel.feature and sequential_signing.feature.
Persistence failure
Using PHPUnit integration with the existing Nextcloud test environment:
- Persist an active unsigned signing request.
- Introduce one controlled failure at the persistence boundary for its removal.
- Execute the cancellation operation.
- Reload the persisted state and observe cancellation events.
Expected:
- The signer remains persisted.
- No cancellation notification is emitted for an unsuccessful removal.
- The operation does not silently report success.
- Unrelated state is unchanged.
Use real persistence wherever possible and the minimum substitution necessary to reproduce the failure.
Sequential flow
Using Behat:
- Create signers A and B at the same first signing order, with C at the next order.
- Before anyone signs, remove pending signer B.
- Verify that A remains active and C is not prematurely activated or notified.
- Complete A's signature.
- Verify that C becomes eligible and receives the expected activation notification once.
This must not depend on modifying signer-removal permissions after a document becomes partially signed.
Boundaries
No generic failure-injection framework, broad notification refactor or new delivery mechanism.
Result and handoff
A passing test may be merged normally.
For a confirmed failure, preserve the test commit and sanitized execution evidence without merging a failing test. Request maintainer review to determine the smallest appropriate fix.
If the required correction extends beyond this investigation, establish a traceable follow-up and carry the same regression test into the corrective work.
- Dominant language
- PHP
- Stars
- 844
- Forks
- 176
- Avg merge
- 14h 3m
- Merged PRs (30d)
- 344
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from LibreSign/libresign
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
OpenSSL engine: leaf certificates get O=Internet Widgits Pty Ltd, ST=Some-State from system openssl.cnfPossibly taken @vitormattos claimed this 5 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LibreSign/libresign#9366 · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
LibreSign/libresign#9007 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LibreSign/libresign#8284 · 5 comments ·
Maintainers usually reply within 1 day
-
frontend javascript technical debt
Difficulty 5/5 Over a week Newbie friendliness 8/100
Maintainers usually reply within 1 day
All issues in LibreSign/libresign
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Automattic/blocks-engine#6318 ·
Maintainers usually reply within 1 day
-
[remove-resource] Delete Open Course Hub, Open Multicourse Hub, and Learn2 with GitSync skeletonsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
-
35-feedback
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day