Classical works detection broken for arrangements of other composers
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
No files, tests, or entry points are named. Start by locating the classical Works detection algorithm and its tests, then trace how composer and arranger relationships are compared. Done means arrangements such as Mozart’s early piano concertos and the F. A. E. Sonata are detected as works without breaking existing cases.
Written by the indexing model from the issue text.
Description
The current algorithm for detection of classical "Works" insists that the composer field be identical for all movements in a work. This is not always the case, and it fails in quite a few cases, the most prominent being Mozart's first four piano concertos, which are arrangements of movements by other composers:
https://en.wikipedia.org/wiki/Piano_Concertos_Nos.1%E2%80%934(Mozart)
in which case any attempt to tag any of the complete a complete cycles of these always fails. For example the MusicBrainz release Murray Perahia playz Mozart, which has been mis-entered in MusicBrainz with multiple composer relationships including "Wolfgang Amadeus Mozart".
Ideally the audio files of these recordings ought to be tagged with COMPOSER="Hermann Raupach", for example and ARRANGER="Wolfgang Amadeus Mozart".
Another example is the F. A. E. sonata
I suggest that the "same composer" criterion be relaxed in two respects:
- If there are multiple composers listed, consecutive movements with the same composer at any position in the list should be considered part of the same work. This will allow tagging the work with a COMPOSER list containing the arranger.
- I suggest that tag ARRANGER be considered as equivalent to COMPOSER for the purposes of works detection only. This would further allow the tagging to better reflect reality.
- Dominant language
- Perl
- Stars
- 1.8k
- Forks
- 386
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 14
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from LMS-Community/slimserver
-
Sync playback crashes repeatedly in a sync group (v9.1.1)Possibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
LMS-Community/slimserver#1701 · 6 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
LMS-Community/slimserver#1555 · 2 comments ·
Maintainers usually reply within 1 day
-
Windows: DST timestamp "fix" (bug 18078) marks ~90% of library as changed after every clock change; freezes server when triggered by a folder browsePossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 4/5 3-5 days Newbie friendliness 45/100
LMS-Community/slimserver#1707 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
LMS-Community/slimserver#1706 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
LMS-Community/slimserver#1683 · 3 comments ·
Maintainers usually reply within 1 day
All issues in LMS-Community/slimserver
Similar issues
-
✏️ Editing - Tags
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
openfoodfacts/openfoodfacts-server#15127 ·
Maintainers usually reply within 1 day
-
FIDO2 (ecdsa-sk / ed25519-sk) ingress keys rejected: missing in get_supported_ssh_algorithms_listOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ovh/the-bastion#695 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
darold/pgFormatter#425 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
observablt-ci
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
elastic/golang-crossbuild#840 ·
Maintainers usually reply within 1 day