validate --fix ignores the 'fixable' metadata; rules marked 'safe' are never auto-fixed
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #416 by @Kuldeep2822k — merged
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- cli
Research direction
Start in src/cli/validate.ts around lines 122-161, where the fix engine matches issue.ruleId against 'valid-review-fields' and never reads the fixable field. Check the ValidationFixability type and the rule declarations in src/validation/types.ts (lines 34 and 154-155) to see what 'safe' currently means. Done means either the 'safe' rules are actually repaired by --fix, or the scope is documented and the metadata relabeled. The maintainer has not picked between those two options, so confirm the direction in the issue before writing code.
Written by the indexing model from the issue text.
Description
Location: src/cli/validate.ts:122-161; src/validation/types.ts:34,154-155
The fix engine hardcodes issue.ruleId === 'valid-review-fields' (itself declared fixable:'manual') and never reads fixable. Every rule declared fixable:'safe' (valid-topic-mastery, valid-session-index, valid-hot-memory) is never touched. The ValidationFixability type and all 19 declarations are effectively decorative.
Fix: Dispatch off fixable==='safe' with per-rule repair fns, or document the scope and relabel the metadata.
From the 2026-10-10 codebase audit sweep (CODEBASE_AUDIT.md).
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 0
- Avg merge
- 22h 21m
- Merged PRs (30d)
- 167
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Kuldeep2822k/cli
-
core priority: medium tests
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Kuldeep2822k/cli#484 ·
Maintainers usually reply within 1 day
-
bug core priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Kuldeep2822k/cli#343 · 1 comment ·
Maintainers usually reply within 1 day
-
bug core priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Kuldeep2822k/cli#342 · 1 comment ·
Maintainers usually reply within 1 day
-
build dependencies documentation refactor
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Kuldeep2822k/cli#531 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
Kuldeep2822k/cli#522 ·
Maintainers usually reply within 1 day
All issues in Kuldeep2822k/cli
Similar issues
-
freshness freshness:observed-only
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
thoroc/context-radar#282 ·
-
bug P2 rust
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
area: web
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
gabe-santana/arkdraw#25 ·
-
bug require-triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
expressjs/expressjs.com#2549 · 1 reaction ·
Maintainers usually reply within 1 day
-
bug good first issue hacktoberfest
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
codercops/discord-bot#101 · 1 comment ·
Maintainers usually reply within 1 day