Donut: the small caption line is cut off in every language
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 1/100
Research direction
The issue describes the Donut toolbar caption and preset chip clipping, and names DonutMenu.MakeCaption, ToolbarPage.axaml, DonutLabelPlacementTests, and the RenderTests screenshots. Start by reviewing the ready branch's three-file change and the named tests. Done when captions wrap where there is room, preset chips show an ellipsis at the palette edge, and the relevant tests pass; a fix is already prepared on a branch.
Written by the indexing model from the issue text.
Description
On the image donut (Settings → Donut toolbar, profile "Images"), the slice "Half size" shows its caption as
"Same for…" instead of "Same format". The same happens in Spanish ("Mismo for…") and Portuguese
("Mesmo fo…"): the caption line gets the slice's width and a single line, about 8 characters on that small donut.
Expected: the caption wraps to a second line where the slice is deep enough, like the slice name does.
Seen in the page-toolbar-*.png screenshots of RenderTests (en, es, pt-BR).
Related: in the "Available presets" list on the same page, a chip wider than the palette is cut at its edge
(with the French translation of #359: "Retourner horizontalement · Inch…").
A fix is ready
Branch devohmycode:fix/donut-caption-wrap, one commit, 3 files:
DonutMenu.MakeCaption: the caption takes two lines whenlabel.Height + 28 < maxHeight, otherwise one as before.
After the change "Same format", "Mismo formato", "Mesmo formato" and "Ten sam format" all show in full on the
Donut toolbar page.ToolbarPage.axaml: the palette chip is aDockPanelwithTextTrimming="CharacterEllipsis", so a chip wider
than the palette ends in "…" instead of being cut at the edge. This part is not checked on a screenshot: the
English chips are not wide enough to show it.DonutLabelPlacementTests: a test that a wide caption wraps where there is room and stays on one line otherwise.
RenderTests, DonutFlipTests, DonutLabelPlacementTests and the toolbar tests pass locally (329 tests).
I can open a pull request from this branch if you'd like.
- Dominant language
- C#
- Stars
- 3.6k
- Forks
- 192
- Avg merge
- 4h 6m
- Merged PRs (30d)
- 158
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from KnifeLemon/Filee
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
KnifeLemon/Filee#363 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 35/100
KnifeLemon/Filee#362 ·
Maintainers usually reply within 1 day
-
关闭软件的时候,鼠标会卡顿五秒左右Openbug
Difficulty 3/5 1-2 days Newbie friendliness 25/100
KnifeLemon/Filee#358 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 5/5 Over a week Newbie friendliness 38/100
KnifeLemon/Filee#356 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
KnifeLemon/Filee#355 ·
Maintainers usually reply within 1 day
All issues in KnifeLemon/Filee
Similar issues
-
/api/oauth/introspect emits clientId and tokenType instead of RFC 7662's client_id and token_typeOpenbug P2
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nightscout/nocturne#2317 ·
Maintainers usually reply within 1 day
-
[BUG]: Position intent set on a simple order is dropped when it becomes a bracket, OCO or OTO orderPossibly taken @RaphaelFakhri claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
alpacahq/alpaca-trade-api-csharp#903 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
joinrpg/joinrpg-net#5752 ·
Maintainers usually reply within 1 day
-
bug ux
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
CodeForFire/lagebuch#714 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
dimitar-radenkov/Pointframe#294 ·
Maintainers usually reply within 1 day