Clarify how descriptor pool capacity is shared across descriptor sets
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 85/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- cpp
- Domain
- documentation
Research direction
The issue points to the Descriptor pool section at 05_Uniform_buffers/01_Descriptor_pool_and_sets.html#_descriptor_pool. Read that section and clarify that descriptor counts apply to the whole pool and are shared by sets allocated from it. Done when the explanation explicitly resolves whether the count is total or per set.
Written by the indexing model from the issue text.
Description
Hi! I was reading the Descriptor pool section and found this sentence a little ambiguous:
We first need to describe which descriptor types our descriptor sets are going to contain and how many of them, using
vk::DescriptorPoolSizestructures.
I wasn't sure whether the descriptor counts refer to the entire pool or to each descriptor set.
For example, with:
vk::DescriptorPoolSize poolSize{
.type = vk::DescriptorType::eUniformBuffer,
.descriptorCount = 3
};
Does this mean 3 uniform buffer descriptors in total, shared by all sets allocated from the pool, or 3 descriptors per set?
The following explanation helps, but I think it would be clearer to state this explicitly. Maybe something like:
These counts are for the entire pool, not for each descriptor set. All descriptor sets allocated from the pool share this capacity.
Thanks for maintaining the tutorial!
- Dominant language
- C++
- Stars
- 444
- Forks
- 145
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from KhronosGroup/Vulkan-Tutorial
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
KhronosGroup/Vulkan-Tutorial#551 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 76/100
KhronosGroup/Vulkan-Tutorial#544 ·
Maintainers usually reply within 1 day
-
Clarify front-face culling when using a negative viewport heightPossibly taken @1sgtpepper claimed this 18 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
KhronosGroup/Vulkan-Tutorial#534 ·
Maintainers usually reply within 1 day
-
Stale GLSL-specific wording in the Vertex Input Description chapterPossibly taken @gpx1000 claimed this 27 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
KhronosGroup/Vulkan-Tutorial#528 · 1 assignee ·
Maintainers usually reply within 1 day
-
Clarify vertex input bindingsPossibly taken @SaschaWillems claimed this 27 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
KhronosGroup/Vulkan-Tutorial#527 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in KhronosGroup/Vulkan-Tutorial
Similar issues
-
Documentation: Fix parameter markup, legacy branch link, and phrasing in Detachable Joints and Model Command tutorialsPossibly taken @patelshivani2283-lab claimed this today. Open
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Niko1221/Strata#6071 · 2 comments ·
Maintainers usually reply within 4 days
-
pumpOpen
Difficulty 1/5 Under an hour Newbie friendliness 68/100
dewenni/ESP_Buderus_KM271#191 ·