add a helper function to get the maximum work-group size

Open
#2,586 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
testing-qa

Research direction

The issue names no files, tests, or entry points. Start by locating the harness code and current queries for CL_DEVICE_MAX_WORK_GROUP_SIZE, CL_DEVICE_MAX_WORK_ITEM_SIZES, and CL_KERNEL_WORK_GROUP_SIZE, then review the linked pull-request discussion. Done means a helper for at least 1D maximum work-group size is added and appropriate existing queries are evaluated for replacement.

Written by the indexing model from the issue text.

Description

See: https://github.com/KhronosGroup/OpenCL-CTS/pull/2578#pullrequestreview-3480072911

We should consider adding a helper function to the harness to get the maximum 1D work-group size at the very least. The maximum 1D work-group size would take into account CL_DEVICE_MAX_WORK_GROUP_SIZE, CL_DEVICE_MAX_WORK_ITEM_SIZES, and possibly CL_KERNEL_WORK_GROUP_SIZE when a kernel object is known.

We could consider adding a helper function for 2D and 3D work-group sizes, also, but I'm less sure how this would work.

Once we have added the new harness function, we should evaluate places where we are currently querying either CL_DEVICE_MAX_WORK_GROUP_SIZE, CL_DEVICE_MAX_WORK_ITEM_SIZES, and CL_KERNEL_WORK_GROUP_SIZE, and see if it would be more appropriate to use the helper function instead.

Dominant language
C++
Stars
234
Forks
240
Avg merge
6d 12h
Merged PRs (30d)
15

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from KhronosGroup/OpenCL-CTS

All issues in KhronosGroup/OpenCL-CTS

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.