test_compiler: feature macros for cl_ext_float_atomics are not tested
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- cpp
- Domain
- testing-qa
Research direction
Start in test_feature_macro.cpp, the compiler test named in the issue. Review how it checks feature macros and compare each cl_ext_float_atomics macro with the corresponding CL_DEVICE_HALF_FP_ATOMIC_CAPABILITIES_EXT, CL_DEVICE_SINGLE_FP_ATOMIC_CAPABILITIES_EXT, or CL_DEVICE_DOUBLE_FP_ATOMIC_CAPABILITIES_EXT bit. Done means every listed macro is checked as defined exactly when its capability bit is set.
Written by the indexing model from the issue text.
Description
Reported by @karolherbst in #2142 (https://github.com/KhronosGroup/OpenCL-CTS/issues/2142#issuecomment-5181820719).
test_feature_macro.cpp does not check the feature macros defined by cl_ext_float_atomics. Each macro should be defined exactly when the
corresponding bit is set in CL_DEVICE_{HALF,SINGLE,DOUBLE}_FP_ATOMIC_CAPABILITIES_EXT:
__opencl_c_ext_fp16_{global,local}_atomic_load_store__opencl_c_ext_fp{16,32,64}_{global,local}_atomic_add__opencl_c_ext_fp{16,32,64}_{global,local}_atomic_min_max
- Dominant language
- C++
- Stars
- 234
- Forks
- 240
- Avg merge
- 6d 12h
- Merged PRs (30d)
- 15
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from KhronosGroup/OpenCL-CTS
-
cognizant-backlog
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
KhronosGroup/OpenCL-CTS#2882 · 1 comment ·
Maintainers usually reply within 1 day
-
cl_khr_command_buffer: negative_enqueue_inconsistent_device expects CL_INCOMPATIBLE_COMMAND_QUEUE_KHR instead of CL_INVALID_DEVICEPossibly taken @kpet claimed this 11 days ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 82/100
KhronosGroup/OpenCL-CTS#2872 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
KhronosGroup/OpenCL-CTS#2699 · 1 comment ·
Maintainers usually reply within 1 day
-
cleanup/refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
KhronosGroup/OpenCL-CTS#2057 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
KhronosGroup/OpenCL-CTS#1198 · 2 comments ·
Maintainers usually reply within 1 day
All issues in KhronosGroup/OpenCL-CTS
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
useless statementOpen
Difficulty 1/5 Under an hour Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
grizzlypeak3d/DJV#962 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day