add tests for multiple SPIR-V OpSpecConstant instructions with the same SpecId
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- testing-qa
Research direction
No files or existing test entry points are named. Start with the linked SPIR-V Registry issue and the top-priority checklist, then locate the OpenCL-CTS tests covering specialization constants and follow their conventions; done means covering the listed same-SpecId cases with and without specialization.
Written by the indexing model from the issue text.
Description
See: https://github.com/KhronosGroup/SPIRV-Registry/issues/357
We should add tests to ensure implementations properly handle cases when multiple OpSpecConstant instructions are decorated with the same SpecId.
Rough test plan:
- Top Priority: Tests for multiple OpSpecConstant instructions:
- Test multiple OpSpecConstant instructions with the same default value without specialization.
- Test multiple OpSpecConstant instructions with the same default value with specialization.
- Test multiple OpSpecConstant instructions with different default values without specialization.
- Test multiple OpSpecConstant instructions with different default values with specialization.
- Additional tests for multiple OpSpecConstant instructions:
- Test multiple OpSpecConstant instructions with different types (but the same size) and different default values without specialization.
- Test multiple OpSpecConstant instructions with different types (but the same size) and different default values with specialization.
- Probably not? Test multiple OpSpecConstant instructions with different types and different sizes. These cases are unable to be specialized, since clSetProgramSpecializationConstant requires the passed-in
spec_sizeto match the size of the specialization constant in the SPIR-V module.
- Tests for boolean OpSpecConstantTrue / OpSpecConstantFalse instructions:
- Test multiple OpSpecConstantTrue instructions without specialization.
- Test mixed OpSpecConstantTrue and OpSpecConstantFalse instructions without specialization.
- Test mixed OpSpecConstantTrue and OpSpecConstantFalse instructions with specialization.
- Additional tests for mixed instructions:
- Test OpSpecConstant and OpSpecConstantNull without specialization.
- Test OpSpecConstant and OpSpecConstantNull with specialization.
- Test OpSpecConstant and either OpSpecConstantTrue or OpSpecConstantFalse without specialization.
- Test OpSpecConstant and either OpSpecConstantTrue or OpSpecConstantFalse with specialization.
- Test OpConstantNull and either OpSpecConstantTrue or OpSpecConstantFalse without specialization.
- Test OpConstantNull and either OpSpecConstantTrue or OpSpecConstantFalse with specialization.
The tests deemed "top priority" are those that I believe are most likely to occur in the wild and are therefore those that I believe we should implement first. The others cover corner cases and could be implemented at a later date, if desired.
- Dominant language
- C++
- Stars
- 234
- Forks
- 240
- Avg merge
- 6d 12h
- Merged PRs (30d)
- 15
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from KhronosGroup/OpenCL-CTS
-
cognizant-backlog
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
KhronosGroup/OpenCL-CTS#2882 · 1 comment ·
Maintainers usually reply within 1 day
-
cl_khr_command_buffer: negative_enqueue_inconsistent_device expects CL_INCOMPATIBLE_COMMAND_QUEUE_KHR instead of CL_INVALID_DEVICEPossibly taken @kpet claimed this 11 days ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 82/100
KhronosGroup/OpenCL-CTS#2872 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
test_compiler: feature macros for cl_ext_float_atomics are not testedPossibly taken @shajder claimed this 10 days ago. Opencognizant-triage
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
KhronosGroup/OpenCL-CTS#2818 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
KhronosGroup/OpenCL-CTS#2699 · 1 comment ·
Maintainers usually reply within 1 day
-
cleanup/refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
KhronosGroup/OpenCL-CTS#2057 ·
Maintainers usually reply within 1 day
All issues in KhronosGroup/OpenCL-CTS
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
useless statementOpen
Difficulty 1/5 Under an hour Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
grizzlypeak3d/DJV#962 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day