type stability: `(::Polynomial)(::ImmutablePolynomial)` composition yields `ImmutablePolynomial`
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start by reproducing the Julia REPL example with Polynomial and ImmutablePolynomial, then trace the callable composition behavior involved in q(p). The issue names no source file or test; done means the composition has a concrete, type-stable return type without incorrectly returning an ImmutableDensePolynomial.
Written by the indexing model from the issue text.
Description
With v4.0.0:
julia> using Test, Polynomials
julia> p = ImmutablePolynomial((1,))
ImmutablePolynomial(1)
julia> q = Polynomial([10, 20])
Polynomial(10 + 20*x)
julia> @inferred q(p)
ERROR: return type Polynomials.ImmutableDensePolynomial{Polynomials.StandardBasis, Int64, :x, 1} does not match inferred return type Any
It doesn't make sense for this composition to return an ImmutableDensePolynomial, because that makes type stability impossible, because the degree of q is not available in the type domain.
- Dominant language
- Julia
- Stars
- 321
- Forks
- 81
- Avg merge
- 10h 1m
- Merged PRs (30d)
- 5
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from JuliaMath/Polynomials.jl
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
JuliaMath/Polynomials.jl#647 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
JuliaMath/Polynomials.jl#641 ·
-
tagbot-manual
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
JuliaMath/Polynomials.jl#627 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 38/100
JuliaMath/Polynomials.jl#620 · 6 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
JuliaMath/Polynomials.jl#585 · 7 comments ·
All issues in JuliaMath/Polynomials.jl
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
bignums
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
JuliaNLSolvers/NLsolve.jl#319 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100