fix CI check on overflow on 32 bit machines
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 83/100
Research direction
Start with the failing expression at test/rational-functions.jl:240 and check how its factorial calls behave on 32 bit machines. Compare using big integers for factorials with lowering the test range; the issue suggests both approaches. Done when the test passes on 32 bit machines without the overflow.
Written by the indexing model from the issue text.
Description
Pade fit: Error During Test at /home/runner/work/Polynomials.jl/Polynomials.jl/test/rational-functions.jl:240
Test threw exception
Expression: pq(1.0) ≈ exp(1) * (-(Base.MathConstants.γ) - sum([((-1) .^ k / k) ./ factorial(k) for k = 1:20]))
OverflowError: 13 is too large to look up in the table; consider using factorial(big(13)) instead
The suggestion could also be don't test to 20.
- Dominant language
- Julia
- Stars
- 321
- Forks
- 81
- Avg merge
- 10h 1m
- Merged PRs (30d)
- 5
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from JuliaMath/Polynomials.jl
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
JuliaMath/Polynomials.jl#641 · 1 comment ·
-
tagbot-manual
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
JuliaMath/Polynomials.jl#627 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 38/100
JuliaMath/Polynomials.jl#620 · 6 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
JuliaMath/Polynomials.jl#585 · 7 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
JuliaMath/Polynomials.jl#584 ·
All issues in JuliaMath/Polynomials.jl
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
JuliaDecisionFocusedLearning/ImplicitDifferentiation.jl#231 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
JuliaDocs/PkgPage.jl#52 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day