Use AverageLoss
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 20/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- julia
- Domain
- machine-learning
Research direction
Start by reading issue 109 and the referenced pull request, then inspect the _solver and _fit dispatch mentioned here. Compare the proposed AverageLoss wrapper with the current implementation and determine whether the type restrictions can be removed or replaced with traits. The issue does not define a settled implementation or completion criteria.
Written by the indexing model from the issue text.
Description
By the way, when I started working on this PR I considered for a moment an alternative implementation with a wrapper
struct AverageLoss{L} <: Loss
loss::L
end
(al::AverageLoss)(x::AVR, y::AVR) = al.loss(x, y)/length(y)
I found this pretty neat, but it would have required some major refactoring, mostly because of the parametric dispatch on glr for _solver, _fit etc. Are all these type restrictions really needed? Or could one get rid of them, maybe with a few traits?
But I am also fine with the current implementation. Please feel free to merge whenever you feel this PR is ready.
Originally posted by @jbrea in https://github.com/JuliaAI/MLJLinearModels.jl/issues/109#issuecomment-1004035779
- Dominant language
- Julia
- Stars
- 86
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from JuliaAI/MLJLinearModels.jl
-
Difficulty 3/5 1-2 days Newbie friendliness 78/100
JuliaAI/MLJLinearModels.jl#187 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 58/100
JuliaAI/MLJLinearModels.jl#180 ·
-
help wanted
Difficulty 5/5 Over a week Newbie friendliness 25/100
JuliaAI/MLJLinearModels.jl#163 · 4 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
JuliaAI/MLJLinearModels.jl#160 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
JuliaAI/MLJLinearModels.jl#159 · 3 comments ·
All issues in JuliaAI/MLJLinearModels.jl
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Sienna-Platform/PowerSimulations.jl#1737 ·
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
FluxML/Optimisers.jl#254 ·
-
Minor: floodplain warning percentage, scalar output error message and a never-true identity checkOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
JuliaAI/MLJTransforms.jl#101 ·
Maintainers usually reply within 1 day
-
@contents blocks fail to render on Julia 1.14Possibly taken @sbfnk claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LuxDL/DocumenterVitepress.jl#410 ·