Remove PyCall as a test dependency by factoring out python model runs
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 58/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Quiet
- Domain
- testing-qa
Research direction
Start by comparing the current Python model code in test/fit/logistic-multinomial.jl with the separated R-model pattern in test/fit/quantile.jl, test/fit/quantile.r.jl, and test/fit/quantile.toml, while reviewing issue #167. Move Python result generation to test/fit/logistic-multinomial_py.jl and have the comparison test read test/fit/logistic-multinomial.toml; done means comparisons still run without PyCall as a test dependency.
Written by the indexing model from the issue text.
Description
For less fragile testing, I propose that the python models, which are currently run in tests to make comparisons with MLJLinearModels, be run separately from tests following the recent model of removing R models, #167.
For example, the code generating python model results now in test/fit/logistic-multinomial.jl is moved to a separate file test/fit/logistic-multinomial_py.jl; running that file serialises the results to a file called test/fit/logistic-multinomial.toml; the remaining DO_COMPARISON code in /fit/logistic-multinomial.jl reads in the data needed for comparisons from the toml file to do the comparisons.
This follows the pattern of the files in test/fit/ now called quantile.jl, quantile.r.jl and quantlile.toml (auto-generated).
- Dominant language
- Julia
- Stars
- 86
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from JuliaAI/MLJLinearModels.jl
-
Difficulty 3/5 1-2 days Newbie friendliness 78/100
JuliaAI/MLJLinearModels.jl#187 · 1 reaction ·
-
help wanted
Difficulty 5/5 Over a week Newbie friendliness 25/100
JuliaAI/MLJLinearModels.jl#163 · 4 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
JuliaAI/MLJLinearModels.jl#160 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
JuliaAI/MLJLinearModels.jl#159 · 3 comments ·
-
multiobjective OLSOpen
Difficulty 5/5 Over a week Newbie friendliness 25/100
JuliaAI/MLJLinearModels.jl#157 ·
All issues in JuliaAI/MLJLinearModels.jl
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Sienna-Platform/PowerSimulations.jl#1737 ·
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
FluxML/Optimisers.jl#254 ·
-
Minor: floodplain warning percentage, scalar output error message and a never-true identity checkOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
JuliaAI/MLJTransforms.jl#101 ·
Maintainers usually reply within 1 day
-
@contents blocks fail to render on Julia 1.14Possibly taken @sbfnk claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LuxDL/DocumenterVitepress.jl#410 ·