Reject invalid icon uploads and serve canonical PNG output
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 52/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- docker, typescript
Research direction
Start by locating the dashboard and Minecraft server icon upload and serving paths, then trace how uploaded bytes are decoded and icons are replaced. Add bounded regression coverage for invalid and valid images, including preservation of the prior icon on failure and both required outputs on success. Confirm successful responses use image/png and nosniff; update the wiki if accepted formats, errors, or limits change.
Written by the indexing model from the issue text.
Description
What to build
Accept instance icons only after successful decoding and canonical PNG conversion. Invalid uploads should produce a clear error and preserve the prior icon.
Context
Related to #65 and closed #47, which concern icon UX/upload access rather than invalid-image handling. No active-content browser execution was demonstrated.
This follows the November 17 source audit. Treat it as a hardening/validation task, not a confirmed exploit report. Detailed audit evidence and validation limitations remain in the local audit report; report any confirmed vulnerability privately under SECURITY.md.
Acceptance criteria
- Decode and validate before replacing either dashboard or Minecraft server icons; remove the raw-byte fallback.
- Serve successful canonical output with explicit image/png and X-Content-Type-Options: nosniff behavior.
- Invalid or unsupported uploads leave the previous icon unchanged; valid uploads still produce both required icons.
- Add bounded invalid/valid-image regression coverage.
- Update the wiki if accepted formats, errors or limits change.
Blocked by
None (can start independently). Coordinate with related issues without expanding their scope.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 0
- Avg merge
- 13h 12m
- Merged PRs (30d)
- 57
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Isopod-Project/Isopod
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Isopod-Project/Isopod#220 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 74/100
Isopod-Project/Isopod#200 ·
Maintainers usually reply within 1 day
-
Dashboard drives high GPU usage while a server starts or restartsPossibly taken @tacoz234 claimed this 12 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Isopod-Project/Isopod#191 · 1 comment ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Isopod-Project/Isopod#134 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Isopod-Project/Isopod#113 ·
Maintainers usually reply within 1 day
All issues in Isopod-Project/Isopod
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
hemilabs/ui-monorepo#2711 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
code-yeongyu/senpi#6929 ·
Maintainers usually reply within 1 day
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 72/100
lingdojo/kana-dojo#34261 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
embedpdf/embed-pdf-viewer#1116 ·
Maintainers usually reply within 1 day
-
current task
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Sunday-School-Software/Sunday-School-Scheduler#87 ·
Maintainers usually reply within 1 day