test: 3524-share-consent credential count depends on the environment
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- testing
Research direction
Read test/suite/regressions/3524-share-consent.test.ts and trace how its preview fixture reaches the generated-value check in share-entropy.ts. Identify values the entropy check sees that vary by environment, then make the test inputs deterministic. Run the named test repeatedly and confirm the preview consistently reports the credential count.
Written by the indexing model from the issue text.
Description
test/suite/regressions/3524-share-consent.test.ts > "shows the preview with the redaction counts and the gist visibility before asking" failed once in a full suite run (shard 4 of 6) and passed when run alone, 3 of 3 at the PR head and 3 of 3 at main's merge-base, in the same container image and limits.
Failure: expected 'Share this session as a secret GitHub…' to match /Removed first: .*credential/; the preview read "Removed first: 2 home paths, 1 email. Images are always left out."
Likely cause (not proven): whether the preview counts a credential depends on the generated-value check in share-entropy.ts. With tool outputs left out, a long random-looking string elsewhere in the export (for example a random temp path) is what gets counted, so the count depends on the environment. Expected: the test controls every value the entropy check sees (fixed temp paths, or a seeded fixture) so the credential count is deterministic.
- Dominant language
- TypeScript
- Stars
- 517
- Forks
- 163
- Avg merge
- 23h 45m
- Merged PRs (30d)
- 691
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from code-yeongyu/senpi
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
code-yeongyu/senpi#6927 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
code-yeongyu/senpi#6890 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
code-yeongyu/senpi#6883 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 66/100
code-yeongyu/senpi#6746 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
code-yeongyu/senpi#6742 ·
Maintainers usually reply within 1 day
All issues in code-yeongyu/senpi
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
hemilabs/ui-monorepo#2711 ·
Maintainers usually reply within 1 day
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 72/100
lingdojo/kana-dojo#34261 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
embedpdf/embed-pdf-viewer#1116 ·
Maintainers usually reply within 1 day
-
current task
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Sunday-School-Software/Sunday-School-Scheduler#87 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Isopod-Project/Isopod#220 ·
Maintainers usually reply within 1 day