Opening Mods during first start can cause Modrinth pack installation to crash on permissions

Open
#202 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
docker, typescript
Domain
backend, devops

Research direction

Begin at get_instance_mods_dir in the instance mods listing code and trace when it creates data/mods, then compare that against the image startup step that fixes ownership under /data. Reproduce with a fresh Docker instance as described, opening Edit → Mods immediately after start. Done means viewing the Mods tab during startup no longer leaves data/mods root-owned with the installer failing, or the failure surfaces as a recoverable error, and pending mods are not counted as installed.

Written by the indexing model from the issue text.

Description

Steps to reproduce

  1. In a fresh Docker installation, create a Modrinth instance using Nitroserver 2.0.0 for Minecraft 1.21.
  2. Start the instance and immediately open Edit, then Mods while it is starting.
  3. Watch startup and the Minecraft log.

Actual

The installer repeatedly fails with java.nio.file.AccessDeniedException: /data/mods/noisium-fabric-2.2.1+mc1.21.jar.download, and the watchdog stops the crash loop. The instance root data directory was owned by UID 1000, but data/mods was owned by root with mode 755. The Mods tab showed the pack mods as “Installs on start” although the header counted them as installed.

Expected

Viewing the Mods tab should not prevent the server process from installing the selected modpack; installation should succeed or report a recoverable error. Pending mods should not be counted as installed.

Investigation

The mods listing calls get_instance_mods_dir, which creates data/mods when absent; the race between this directory creation and the image startup ownership step is a plausible cause and should be verified. Observed on an isolated v0.5.0 Docker dashboard; itzg/minecraft-server java21 image revision 30b26426 and helper 1.76.3.

Dominant language
TypeScript
Stars
1
Forks
0
Avg merge
13h 12m
Merged PRs (30d)
57

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Isopod-Project/Isopod

All issues in Isopod-Project/Isopod

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.