Saving a Bedrock server writes Java resource-pack settings into its config

Open
#140 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
65/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
docker, python, typescript
Domain
backend, testing

Research direction

Start with the resource-pack reset in frontend/src/App.tsx and start_instance in backend/main.py, then trace the existing save flow and tests for server configuration. Add coverage for saving a Bedrock config and check that starting one also omits these keys; confirm Java servers still clear stale settings. Done means all four listed behaviors are covered and pass.

Written by the indexing model from the issue text.

Description

bug

Follow-up to #66.

Bug: Saving a Bedrock server from the Edit window writes Java-only settings into its compose environment. After one save, test-bedrock had:

CUSTOM_SERVER_PROPERTIES: resource-pack-id=
RESOURCE_PACK_ID: ''

The save code in frontend/src/App.tsx (around the RESOURCE_PACK_ID force-reset) runs for every server type, and start_instance in backend/main.py also clears RESOURCE_PACK_ID. Bedrock ignores these keys today, but they clutter the Configuration tab and could clash if itzg's Bedrock image starts reading them.

  • Saving a Bedrock server doesn't add RESOURCE_PACK_ID or CUSTOM_SERVER_PROPERTIES
  • Starting a Bedrock server doesn't add them either
  • Java servers still clear stale resource-pack settings as before
  • A test covers saving a Bedrock config
Dominant language
TypeScript
Stars
1
Forks
0
Avg merge
13h 12m
Merged PRs (30d)
57

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Isopod-Project/Isopod

All issues in Isopod-Project/Isopod

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.