Can't apply control operators to values that the rfc considers valid

Open
  • Is something wrong?
#71 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
haskell
Domain
tooling

Research direction

Start at the CtlOp.Lt branch shown in the issue and compare its PTUInt-only handling with the listed valid forms; use the cddl tool as the behavioral reference. Done means the five examples, along with the analogous control-operator cases mentioned, are accepted rather than rejected.

Written by the indexing model from the issue text.

Description

bug

Because of this code:

    (CtlOp.Lt, CTree.Literal (VUInt n)) -> case tt of
      CTree.Postlude PTUInt -> S . TInteger <$> genUniformRM (0, fromIntegral n - 1)
      _ -> error "Cannot apply lt operator to target"

We can only apply rules like uint .lt 2. It forbids the following cases:

rule1 = nint .lt 2
rule2 = int .lt 2
rule3 = 1..5 .lt 2
rule4 = 1 .lt 2
rule5 = ((1..3) / (1..5)) .lt 2

All these cases are accepted by the cddl tool. The same seems to happen with most of the other control operators.

Dominant language
Haskell
Stars
8
Forks
5
Avg merge
3d 12h
Merged PRs (30d)
4

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from IntersectMBO/cuddle

All issues in IntersectMBO/cuddle

Similar issues

More Haskell issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.