Canonical float equality does not conform to RFC8949
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start by locating the canonical float equality and map key equivalence implementation in the Haskell code, then inspect the related tests. The issue requires integers to remain unequal to floats, equal numeric values across float widths to compare equal, and signed zero and NaN significands to follow RFC 8949 §5.6.1. Add or update tests for these cases and run the relevant test suite.
Written by the indexing model from the issue text.
Description
According to the spec:
RFC8949 §2.
Note that integer and floating-point values are distinct in this
model, even if they have the same numeric value.Also note that serialization variants are not visible at the generic
data model level. This deliberate absence of visibility includes the
number of bytes of the encoded floating-point value. It also
includes the choice of encoding for an "argument" (see Section 3)
such as the encoding for an integer, the encoding for the length of a
text or byte string, the encoding for the number of elements in an
array or pairs in a map, or the encoding for a tag number.
This means that integer types are always unequal to floating point numbers, even if numerically they would be equal. However floating point numbers with different bit widths can still be equal if they represent the same numerical value.
Additionally
RFC8949 §5.6.1.
Within each of these groups, numeric values are distinct unless they
are numerically equal (specifically, -0.0 is equal to 0.0); for the
purpose of map key equivalence, NaN values are equivalent if they
have the same significand after zero-extending both significands at
the right to 64 bits.
- Dominant language
- Haskell
- Stars
- 8
- Forks
- 5
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 4
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from IntersectMBO/cuddle
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
IntersectMBO/cuddle#168 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
IntersectMBO/cuddle#167 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
IntersectMBO/cuddle#166 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 43/100
IntersectMBO/cuddle#223 ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
IntersectMBO/cuddle#215 ·
All issues in IntersectMBO/cuddle
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
IntersectMBO/cardano-ledger#6276 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
OpenZeppelin/canton-contracts#92 ·
Maintainers usually reply within 1 day