editors: escaped f-string braces are highlighted as interpolation
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 75/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- vim, vscode
- Domain
- tooling
Research direction
Start with editors/vscode/syntaxes/eigenscript.tmLanguage.json and editors/vim/syntax/eigenscript.vim, using the lexer f-string escape handling in src/lexer.c as the behavior contract. Reproduce the supplied f-string fixture and inspect scopes before and after in both grammars, with VS Code semantic tokens disabled. Done means escaped braces remain literal, genuine interpolation is scoped as an expression, and existing string escapes continue to work.
Written by the indexing model from the issue text.
Description
The bundled editor grammars treat an escaped opening brace in an f-string as the start of interpolation. EigenScript's lexer treats \{ and \} as literal braces.
Reproduce
print of f"literal \{name\}"
The runtime prints literal {name} without looking up a variable called name. In the VS Code grammar, the f-string escape pattern does not consume the backslash-plus-brace, so the interpolation pattern matches the following {. The Vim escape declaration omits braces too.
Checked at b91768e23c5a874a64e76e4af9ab291e6aa49983:
The runtime output and exact VS Code regex behavior were checked; this report does not claim a GUI/TextMate-engine verification.
First-contribution scope
Correct the two editor grammars so escaped braces retain their string/escape scope and do not start interpolation when they occur in the f-string's literal text. Use the existing lexer behavior as the contract; handling of braces inside an expression is outside this issue. No runtime change is required.
Done when
- Escaped opening and closing braces remain literal f-string content.
- Genuine interpolation still receives an expression scope.
- Mixed literal and interpolated segments work, including an escaped backslash immediately before a genuine interpolation.
- Plain strings and existing quote/backslash escapes keep their behavior.
- Provide a small fixture and before/after scope inspection for both grammars, including VS Code with semantic tokens disabled.
This is suitable for a contributor familiar with regular expressions and editor configuration. It shares files with #1233 and #1234; keep the fix focused and coordinate/rebase if one lands first.
- Dominant language
- C
- Stars
- 3
- Forks
- 7
- Avg merge
- 4h 15m
- Merged PRs (30d)
- 106
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from InauguralSystems/EigenScript
-
area:lint-tooling bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
InauguralSystems/EigenScript#1340 ·
Maintainers usually reply within 1 day
-
area:stdlib found-by:code-review kind:silent-wrong
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
InauguralSystems/EigenScript#1338 ·
Maintainers usually reply within 1 day
-
area:lint-tooling found-by:critic kind:docs-drift
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
InauguralSystems/EigenScript#1335 ·
Maintainers usually reply within 1 day
-
area:ci found-by:critic kind:gate-defect
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
InauguralSystems/EigenScript#1311 ·
Maintainers usually reply within 1 day
-
enrolment: decide test_gc_runner_controls.py (exempt vs enrol) and whether floors need a ratchetOpenarea:gates found-by:critic kind:decision
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
InauguralSystems/EigenScript#1280 · 1 comment ·
Maintainers usually reply within 1 day
All issues in InauguralSystems/EigenScript
Similar issues
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
netdata/netdata#24062 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
riscv-software-src/riscv-isa-sim#2448 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
NabuCasa/silabs-firmware-builder#231 · 1 comment ·