Silver drops Phoenix DeviceEnable (string in bronze)

Open Beginner friendly
#5 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
77/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python

Research direction

Start with src/flashpoint/semantics/silver.py and the P4 spike table in p4-views-and-reports design.md; trace how DeviceEnable values become silver value and are filtered. Add the stated Enabled/Disabled mapping, a Q7 corpus test, and a DERIVE_VERSION bump. Done means the test confirms enabled and disabled states are retained as 1 and 0.

Written by the indexing model from the issue text.

Description

bug

Found during the P4 spike (openspec change p4-views-and-reports, design.md spike table).

Problem: Phoenix 6 DeviceEnable is a string in bronze (v_str), but the silver query builds value as COALESCE(v_f64, CAST(v_bool AS DOUBLE), CAST(v_i64 AS DOUBLE)) (src/flashpoint/semantics/silver.py). Every device_enable row is NULL and gets dropped by WHERE d.value IS NOT NULL, so silver has no per-device enable state even though METRICS maps it.

Impact: per-device enabled time can't be measured; gold/unit_usage.enabled_s uses the robot's enable intervals from framing instead.

Fix sketch: map the known DeviceEnable strings (e.g. Enabled/Disabled) to 1/0 in the silver query, with a corpus test on Q7; bump DERIVE_VERSION.

Dominant language
Python
Stars
0
Forks
1
Avg merge
18h 37m
Merged PRs (30d)
15

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from IgniteRobotics/flashpoint

All issues in IgniteRobotics/flashpoint

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.