Static colour lint misses hex colours in .js files

Open Beginner friendly
#45 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
70/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
css, javascript, python
Domain
frontend, testing

Research direction

Start with tests/web/test_static_lint.py, which already checks hex colours in .css files and rgb(a) channels; the change is to make the same check cover .js files under the view directories. Run the test first to confirm it passes today, then check views/setup.js around lines 289-290 to see the placeholder hex values the lint will flag. Done means the lint fails on a hex colour added to a view's .js file, and passes on the existing setup.js examples via an allow-list or after moving them into data.

Written by the indexing model from the issue text.

Description

tests/web/test_static_lint.py fails on hex colours in .css files and on raw rgb(a) channels. A hex colour in a view's .js file still passes, and that colour would ignore the team palette.

The only hits today are the example input values in views/setup.js (around lines 289-290, harmless placeholders). Extend the lint to .js with an allow-list for those, or move the examples into data.

Found during the team-branding docs review (PR #42).

🤖 Generated with Claude Code

Dominant language
Python
Stars
0
Forks
1
Avg merge
18h 37m
Merged PRs (30d)
15

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from IgniteRobotics/flashpoint

All issues in IgniteRobotics/flashpoint

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.