Windows: tests skipped in P3 (fake sysfs, backslash robot paths)

Open
#3 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
testing

Research direction

Start with tests/acquire/test_volumes_linux.py and tests/acquire/test_transfer.py::test_robot_path_with_backslash_or_colon_is_skipped, then inspect the fake sysfs fixtures and fake SFTP server setup. Compare how the tests create paths on Windows with the Linux and macOS runs. Done means the affected tests run on Windows while still checking the intended parser and path behavior.

Written by the indexing model from the issue text.

Description

enhancement

P3 (IgniteRobotics/flashpoint-private#15) added a windows-latest CI job. These tests are skipped on win32 because they can't run there as written. Each still runs on Linux and macOS.

  • tests/acquire/test_volumes_linux.py: 6 tests that use the fake /sys tree. Linux sysfs device names contain : (e.g. 0000:00:14.0, 6:0:0:0), which NTFS can't create. The Linux parser itself is pure and tested on fixtures. Possible fix: map : in the fake tree, or inject a path-resolver into the parser.
  • tests/acquire/test_transfer.py::test_robot_path_with_backslash_or_colon_is_skipped: the fake robot serves a host temp directory, and Windows can't create files whose names contain \ or :. The inbox_path rule is still unit-tested on every OS. Possible fix: give the fake SFTP server a virtual filesystem.

🤖 Generated with Claude Code

Dominant language
Python
Stars
0
Forks
1
Avg merge
18h 37m
Merged PRs (30d)
15

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from IgniteRobotics/flashpoint

All issues in IgniteRobotics/flashpoint

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.