Publish Dataset button displays a dropdown arrow when only one action is available

Open Beginner friendly
  • Is something wrong?
#12,837 2 comments 2 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
html, java, javascript
Domain
frontend, web-dev

Research direction

Start with src/main/webapp/dataset.xhtml and compare the Publish Dataset button's rendering condition with the Dataverse 6.9 template linked in the issue. Reproduce the case where Publish is the only available action and check that the button has no dropdown arrow while still opening the confirmation dialog; then verify the arrow remains when additional actions are available.

Written by the indexing model from the issue text.

Description

Type: Bug

What steps does it take to reproduce the issue?

  • When does this issue occur?

    1. Open an unpublished draft dataset in Dataverse 6.12.
    2. Ensure that the user has permission to publish the dataset.
    3. Locate the Publish Dataset button.
    4. Observe the dropdown arrow next to the button label.
    5. Click the button.

  • Which page(s) does it occurs on?
    The dataset landing page (dataset.xhtml).

  • What happens?

    The Publish Dataset button displays a dropdown arrow even when Publish is the only available action.

    Clicking the button directly opens the Publish confirmation dialog rather than displaying a dropdown menu.

    The rendered HTML includes , but the button does not have the dropdown-toggle class or data-toggle="dropdown" attribute.

    Comparing the upstream dataset.xhtml templates reveals a change in the condition controlling the arrow.

    Dataverse 6.9: jsf:rendered="#{(showSubmitForReviewLink or showReturnToAuthorLink) and showPublishLink}"
    Dataverse 6.12: jsf:rendered="#{(showSubmitForReviewLink or showReturnToAuthorLink or showPublishLink)}"
    In 6.12, the arrow is displayed whenever showPublishLink is true, even if no additional actions are available.

  • To whom does it occur (all users, curators, superusers)?
    Users with permission to publish a dataset when Publish is the only available action. The issue was observed with an account authorized to publish datasets.

  • What did you expect to happen?

    The Publish Dataset button should display a dropdown arrow only when multiple actions are available.

    When Publish is the only available action, the button should appear without a dropdown arrow and continue opening the Publish confirmation dialog directly.

Which version of Dataverse are you using?
v. 6.12.1 build master-bddc062

Any related open or closed issues to this bug report?
Relevant source files:

Dataverse 6.9 – dataset.xhtml

Dataverse 6.11 – dataset.xhtml

Dataverse 6.12 – dataset.xhtml

Screenshots:

6.8：

Image

6.12：

Image
Dominant language
Java
Stars
1.1k
Forks
571
Avg merge
1d 17h
Merged PRs (30d)
11

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from IQSS/dataverse

All issues in IQSS/dataverse

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.