Language controlled vocabulary displays 'Logudorese Sardinian, Croatian' instead of 'Croatian'
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- java
- Domain
- internationalization
Research direction
Read the affected entries in scripts/api/data/metadatablocks/citation.tsv and src/main/java/propertyFiles/citation.properties. Separate the Croatian and Logudorese Sardinian vocabulary records, then check that each language has the correct displayed label in the alphabetical sections. Done when Croatian appears as its own entry under C and Logudorese Sardinian appears under L in the dataset language dropdown.
Written by the indexing model from the issue text.
Description
What steps does it take to reproduce the issue?
-
When does this issue occur?
When selecting the language of a dataset in the Citation metadata block. -
Which page(s) does it occur on?
Dataset create / edit metadata page (dataset.xhtml). -
What happens?
In the Citation Metadata controlled vocabulary dropdown for the Language field (language), Croatian is displayed asLogudorese Sardinian, Croatianinstead ofCroatian. When typing "Croatian" into the dropdown filter, it only matches this combined entry. -
To whom does it occur (all users, curators, superusers)?
All users editing dataset citation metadata. -
What did you expect to happen?
The dropdown should displayCroatianas its own entry under "C".
Which version of Dataverse are you using?
Affects all versions from v6.4 up to and including v6.12.1 and current develop branch.
Root Cause Analysis:
Two lines were concatenated during the expansion of the ISO 639 language controlled vocabulary in v6.4:
-
scripts/api/data/metadatablocks/citation.tsv(line 1561 ondevelop):language Croatian hrv 1418 hrv Logudorese Sardinian src hr CroatianThe record for Croatian (
hrv, ISO 639-1hr) and Logudorese Sardinian (src) were accidentally joined into a single TSV line without a newline delimiter. -
src/main/java/propertyFiles/citation.properties(line 4093 ondevelop):controlledvocabulary.language.logorik=Logorik controlledvocabulary.language.croatian=Logudorese Sardinian, Croatian controlledvocabulary.language.lohorung=Lohorungcontrolledvocabulary.language.croatianis incorrectly placed in the "L" alphabetical section betweenlogorikandlohorung(whereLogudorese Sardinianbelongs).controlledvocabulary.language.croatianis completely missing from the "C" section (aftercroatia_sign_language).
Suggested Fix:
-
In
scripts/api/data/metadatablocks/citation.tsv:
Restore the discrete Croatian entry and separate Logudorese Sardinian:- language Croatian hrv 1418 hrv Logudorese Sardinian src hr Croatian + language Croatian hrv 1418 hrv hr + language Logudorese Sardinian src 3785 src -
In
src/main/java/propertyFiles/citation.properties:
Addcontrolledvocabulary.language.croatian=Croatianto the "C" section:controlledvocabulary.language.croatia_sign_language=Croatia Sign Language controlledvocabulary.language.croatian=Croatian controlledvocabulary.language.cross_river_mbembe=Cross River MbembeAnd update line 4093 in the "L" section:
controlledvocabulary.language.logorik=Logorik controlledvocabulary.language.logudorese_sardinian=Logudorese Sardinian controlledvocabulary.language.lohorung=Lohorung
Any related open or closed issues to this bug report?
None found.
Are you thinking about creating a pull request for this issue?
Yes, we have verified this patch on Payara 7 / JDK 21 / Dataverse 6.12.1 and can provide a PR against develop if requested.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 568
- Avg merge
- 5d 7h
- Merged PRs (30d)
- 26
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from IQSS/dataverse
-
Release Size: 30
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
docs: remove obsolete chown command and follow-up notePossibly taken @donsizemore claimed this 18 days ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
IQSS/dataverse#12764 · 1 reaction ·
Maintainers usually reply within 1 day
-
S3SubmitToArchiveCommand: temporary bag files not deleted after upload, causing disk space leakOpenType: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
IQSS/dataverse#12736 · 1 comment ·
Maintainers usually reply within 1 day
-
Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
IQSS/dataverse#12735 · 1 comment ·
Maintainers usually reply within 1 day
-
Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
IQSS/dataverse#12734 · 1 comment ·
Maintainers usually reply within 1 day
Similar issues
-
[Bug] dubbo.protocol.triple.max-message-size is only read from OS environment variablesPossibly taken @CCCLL claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
hierynomus/sshj#1070 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
intellij-elixir/intellij-elixir#4492 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
quarkiverse/quarkus-openapi-generator#1796 · 1 comment ·