A durable commit is reported as failed when aftercommit hits a database closed after the commit
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- javascript, node.js
- Domain
- database
Research direction
Start with Transaction.commit() and commitSync() in src/transaction.ts, then trace how notify failures reach db.transaction() after a successful commit. The issue leaves the desired handling open, so first determine how the project represents durable commits and reports notification failures. Done means a notification error after a durable commit cannot make the caller treat that commit as failed or retry its writes.
Written by the indexing model from the issue text.
Description
Problem
Transaction.commit() and commitSync() (src/transaction.ts) emit aftercommit after a successful commit. If the database is closed by another env between the durable commit and that notification, notify throws "Database not open" and the commit rejects. db.transaction() then abandons a transaction that is already durable, and a caller that retries non-idempotent writes after that error duplicates them.
Found while fixing #1100 (a failing notification no longer replaces a failed commit's own error); the success path was deliberately left unchanged there.
Possible direction
Decide whether a notify failure after a successful commit should be reported at all (for example, drop it or surface it through a log warning), and make db.transaction() aware that the commit was durable.
Review-Deferral: a9ad197ae1fd2aa0 severity=minor category=data-integrity
🤖 Generated by Anthropic Claude (Sonnet 5.5); posted via @cb1kenobi.
- Dominant language
- C++
- Stars
- 24
- Forks
- 3
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 94
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from HarperFast/rocksdb-js
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
HarperFast/rocksdb-js#1118 ·
Maintainers usually reply within 1 day
-
CLI crashes with ENOTCONN instead of exiting 0 when stdout closes on macOSPossibly taken @cb1kenobi claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
HarperFast/rocksdb-js#1112 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 4/5 1-2 days Newbie friendliness 38/100
HarperFast/rocksdb-js#1114 ·
Maintainers usually reply within 1 day
-
Release builds abort the process when an internal native assert failsPossibly taken @cb1kenobi claimed this today. Openbug
HarperFast/rocksdb-js#1113 · 1 assignee ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 30/100
HarperFast/rocksdb-js#1111 ·
Maintainers usually reply within 1 day
All issues in HarperFast/rocksdb-js
Similar issues
-
bug triage
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
26.04 bug dark-mode Easy Hack impress symptom: visual
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
CollaboraOnline/online#16421 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
telegramdesktop/tdesktop#31653 ·
Maintainers usually reply within 1 day
-
area/cs bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
ydb-platform/ydb#59881 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day