ecce-reconnect, ecce-fetch, ecce-terminate wait the full timeout when the Organizer dies after acknowledging

Open
  • Is something wrong?
#816 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
1-2 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
c
Domain
cli

Research direction

Start with the wait loop that the ecce-reconnect, ecce-fetch and ecce-terminate commands share, which uses kBatchSeconds (300 s) while waiting for the Organizer's answer. Read how the session records the Organizer's pid and how the broker is used, since the issue proposes either a pid check or a broker last-will. Done means a command whose Organizer dies after acknowledging exits at once with 'the Organizer ended before answering'. Choosing the liveness mechanism needs a maintainer decision first, so check with them before writing code.

Written by the indexing model from the issue text.

Description

Found with #814: after the Organizer acknowledges a request, the command-line tool waits up to 300 s for the answer (kBatchSeconds). If the Organizer has crashed in between, the user sees nothing for five minutes. A liveness check (e.g. the session's Organizer pid or a broker last-will) would turn this into an immediate error: 'the Organizer ended before answering'.

Dominant language
C
Stars
10
Forks
8
Avg merge
21m
Merged PRs (30d)
1

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from FriendsofECCE/ECCE

All issues in FriendsofECCE/ECCE

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.