Allow-list (whitelist) for keyword-based message blocking
Maintainers usually reply within 1 day
Nobody has claimed this yet.
- #848 by @imyoga — closed without merging
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 30/100
Research direction
Start by reading the existing keyword-blocking implementation and tracing where incoming messages are checked against the blacklist. The issue does not name files or tests, so locate those entry points in the repository first. Done means allow-list matches bypass the blacklist and are delivered normally, including when they also match a blocked keyword.
Written by the indexing model from the issue text.
Description
Checklist
- I made sure that there are no existing issues - open or closed - to which I could contribute my information.
- I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
- I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
- I have taken the time to fill in all the required details. I understand that the request will be dismissed otherwise.
- This issue contains only one feature request.
- I have read and understood the contribution guidelines.
Feature description
The app currently supports blocking messages that contain specific keywords, but there's no way to define exceptions. If a legitimate message happens to contain a blocked keyword (for example, a bank notification that includes a word also used by spam messages), it gets blocked along with the actual spam, with no way to let it through.
Why do you want this feature?
Add a second list of keywords/phrases that work as a whitelist. When an incoming message matches an allow-list entry, it should bypass the keyword blacklist check entirely and be delivered normally, even if it also matches a blacklisted keyword. This would let users write broader, more effective blacklist rules (e.g. regex-based) without worrying about false positives on messages they actually want to receive.
Additional information
Some other SMS filtering tools (e.g. NekoSMS, CC SMS Blocker) implement this blacklist + whitelist combination, with whitelist rules taking priority over blacklist rules. Happy to attempt a PR for this once the direction is agreed on.
- Dominant language
- Kotlin
- Stars
- 1.6k
- Forks
- 187
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 20
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from FossifyOrg/Messages
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
FossifyOrg/Messages#897 · 1 comment ·
Maintainers usually reply within 1 day
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
FossifyOrg/Messages#761 ·
Maintainers usually reply within 1 day
-
[Export] mms "No entries for export have been found"May be free again A pull request for this issue was closed without being merged. Openbug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
FossifyOrg/Messages#493 · 24 comments · 3 reactions ·
Maintainers usually reply within 1 day
-
bug needs triage
Difficulty 3/5 1-2 days Newbie friendliness 56/100
FossifyOrg/Messages#902 ·
Maintainers usually reply within 1 day
-
feature request needs triage
Difficulty 5/5 Over a week Newbie friendliness 28/100
FossifyOrg/Messages#900 ·
Maintainers usually reply within 1 day
All issues in FossifyOrg/Messages
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lugassawan/swe-workbench#799 ·
Maintainers usually reply within 1 day
-
Default book icon displayed while loadingPossibly taken @Bhaskar-Guthula-137 claimed this today. Openbug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
kiwix/kiwix-android#5194 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
jellyfin/jellyfin-androidtv#5885 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 73/100
tortuvshin/open-apps#377 ·
Maintainers usually reply within 1 day
-
contributor: external needs review
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day