[UI/UX] Bottom bar item color should match top bar color for consistent contrast
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start with ViewPagerActivity.kt and activity_view_pager.xml, where the issue identifies the bottom bar items and their independent styling. Compare their color handling with the top bar's updateMenuItemColors menu hook and the shared color logic it uses. Done means the bottom bar follows the same color selection and contrast behavior as the top bar.
Written by the indexing model from the issue text.
Description
Checklist
- I can reproduce the bug with the latest version given here.
- I made sure that there are no existing issues - open or closed - to which I could contribute my information.
- I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
- I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
- I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
- This issue contains only one bug.
- I have read and understood the contribution guidelines.
Affected app version
1.13.1
Affected Android/Custom ROM version
16 stock
Affected device model
motorolaedge 50 ultra
How did you install the app?
F-Droid / IzzyOnDroid
Steps to reproduce the bug
Open Fossify Gallery.Open any image or video to enter the full-screen view (ViewPagerActivity).Observe the text/icon color of the top bar items.Compare it with the color of the bottom bar action items.[Optional] Change the app theme or view a very bright/dark image to see where the contrast on the bottom bar drops.
Expected behavior
The icons in the bottom bar should dynamically inherit or follow the exact same color selection and contrast-calculation logic as the top bar items, ensuring they remain highly visible against the semi-transparent background overlay.
Actual behavior
BehaviorThe bottom bar items use a separate styling path, causing an inconsistency in color and poor contrast under certain theme/media conditions compared to the top bar.
Screenshots/Screen recordings
No response
Additional information
Currently, the items in the bottom action bar (Favorite, Edit, Share, Delete) do not follow the same color logic/theme choices as the items in the top bar (Back, Name, Rotate, Info, etc.) when viewing media in full-screen mode.Because the background behind these toolbars is semi-transparent, the current color implementation for the bottom bar items sometimes results in a lack of contrast. This makes the icons difficult to see depending on the media being viewed or the active system theme. Aligning the bottom bar's tinting logic with the top bar will ensure visual consistency and guarantee sufficient contrast across the entire user interface.
The top bar items are tinted globally via menu lifecycle hooks (like updateMenuItemColors utilizing FossifyOrg/commons).The bottom bar items (IDs like viewer_favorite, viewer_edit, etc. in activity_view_pager.xml) are styled independently in ViewPagerActivity.kt and should be refactored to share the same color definition source as the top bar.
- Dominant language
- Kotlin
- Stars
- 3.8k
- Forks
- 270
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 12
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from FossifyOrg/Gallery
-
bug needs triage
Difficulty 2/5 Half a day Newbie friendliness 60/100
FossifyOrg/Gallery#1181 ·
Maintainers usually reply within 1 day
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
FossifyOrg/Gallery#1167 ·
Maintainers usually reply within 1 day
-
Instead of the trash symbol on the main page with folders, add a delete option to the dropdown menu.Openfeature request needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
FossifyOrg/Gallery#1165 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
feature request needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
FossifyOrg/Gallery#1153 ·
Maintainers usually reply within 1 day
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
FossifyOrg/Gallery#1136 ·
Maintainers usually reply within 1 day
All issues in FossifyOrg/Gallery
Similar issues
-
Moshi and Gson JSON adapters fail for messages with a map<bool, V> fieldPossibly taken @auraseb claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
bug Missing saved game
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
yairm210/Unciv#15826 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
AniTrend/anitrend-v2#1344 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
zhanghai/MaterialFiles#1659 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Droid-Deck/DroidDeck#1098 ·
Maintainers usually reply within 1 day