[BUG] Leading space in offset number causes LRC parse error
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
Research direction
Start by locating the LRC parsing code and its tests in the Kotlin Android app, then check how the offset tag is parsed when its numeric value has leading whitespace. Reproduce with [offset: 500] and compare with [offset:500]; done means the lyric loads without showing the parse error and the offset is respected.
Written by the indexing model from the issue text.
Description
Describe the bug
Player failed to parse LRC files which contains offset number with leading space, like [offset: 500] instead of [offset:500]. The number was set with MiniLyrics on Windows.
To Reproduce
Steps to reproduce the behavior:
- Open Gramophone
- Play any song with LRC file containing offset tag mentioned above
- Open lyric view
- See error, entire content of LRC file also displayed
Expected behavior
LRC file loaded properly
Screenshots
Both of my smartphones displays same error. Translation: Failed to parse lyric
Smartphone (please complete the following information):
- Device: Oppo A5s & Poco M4 Pro
- OS: Android 8.1.0 (ColorOS V5.2.1) & Android 13 TP1A.220624.014 (HyperOS 1.0.8.0.TKEIDXM)
- App Version: 1.1.2
Additional context
If I remove leading space, LRC loaded properly and respects offset setting.
- I will open one issue per bug, follow the issue format and will add
[BUG]to the start of my issue title, and I acknowledge that if I don't follow the format, my issue might get closed without further explanation.
- Dominant language
- Kotlin
- Stars
- 2.3k
- Forks
- 136
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from FoedusProgramme/Gramophone
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
FoedusProgramme/Gramophone#1048 ·
-
need confirm
Difficulty 4/5 3-5 days Newbie friendliness 48/100
FoedusProgramme/Gramophone#1051 · 2 comments ·
-
need confirm
Difficulty 3/5 1-2 days Newbie friendliness 45/100
FoedusProgramme/Gramophone#1050 ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 48/100
FoedusProgramme/Gramophone#1049 · 5 comments ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 45/100
FoedusProgramme/Gramophone#1047 ·
All issues in FoedusProgramme/Gramophone
Similar issues
-
design good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
scribe-org/Scribe-Android#739 ·
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
xybrid-ai/xybrid#661 · 1 comment ·
Maintainers usually reply within 1 day
-
android bug kotlin vulkan
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
maplibre/maplibre-native-ffi#852 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
bug widget
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
home-assistant/android#7654 · 1 comment ·
Maintainers usually reply within 1 day