Slice.to_global drops upper-face nodes of meshes without a neighbour
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 70/100
Research direction
Start in slcf/slice.py at Slice.to_global() and read the “We ignore border points ...” step, then look for tests covering this method. Reproduce the reported L-shaped, 8-mesh case and check that upper-face nodes are retained from their own mesh when no neighbour covers them; done means those exterior-wall values are no longer NaN.
Written by the indexing model from the issue text.
Description
Slice.to_global() (1.11.7 and 1.12.1, slcf/slice.py, the "We ignore border points ..." step) drops the last node row of every mesh on its upper x/y face and adds it back only at the global maximum, assuming a neighbouring mesh supplies those nodes. Where no neighbour exists, on a domain that does not fill its bounding box (e.g. an L-shaped corridor), the nodes stay NaN although FDS wrote them.
Example: an L-shaped corridor of 8 meshes at 0.25 m, node-based SLCF at z = 2.0 m. 208 nodes on the exterior walls are NaN for this reason. All of them lie on upper faces of meshes below the global maximum; none is strictly inside a mesh. The values are present in each mesh's subslice data.
Expected: an upper-face node is taken from its own mesh when no neighbouring mesh covers it.
Found through fdsvismap, which reads slices with to_global().
- Dominant language
- Python
- Stars
- 75
- Forks
- 28
- Avg merge
- 2m
- Merged PRs (30d)
- 2
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from FireDynamics/fdsreader
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
FireDynamics/fdsreader#125 ·
-
Slice.to_global puts the second-to-last node row on the domain's upper facesPossibly taken @chraibi claimed this 3 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
FireDynamics/fdsreader#123 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
FireDynamics/fdsreader#122 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 76/100
FireDynamics/fdsreader#120 · 2 comments ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
FireDynamics/fdsreader#115 · 1 comment ·
All issues in FireDynamics/fdsreader
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
UKGovernmentBEIS/inspect_ai#5802 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
no-human-ai/no_human#660 ·
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
documentation need help question
Difficulty 1/5 1-3 hours Newbie friendliness 66/100
phonology024/babelscribe#26 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100