problem with sync and saving data from editor
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
Research direction
Start by tracing AppRepository.replaceDownloadedPage, PageDataManager's cache, and how PageSaver handles pending edits. Work out what should happen to cached pages and unsaved edits when a download replaces a page, then add regression coverage for reopening and editing after sync; done means the downloaded data is shown without mixing it with stale edits.
Written by the indexing model from the issue text.
Description
When sync downloads a page, AppRepository.replaceDownloadedPage replaces its strokes and images in the database, but PageDataManager is not told. A page still in its cache (for example from a notebook just closed to sync it) keeps its old strokes:
- reopening the notebook shows the old local version until the page is evicted;
- edits made to it are saved on top of the downloaded page (by stroke and image id), mixing both versions in the database.
This is not new: it behaved the same before #354, when the editor wrote each edit right away instead of through PageSaver. #354 only makes sure edits are saved before a sync reads pages.
Possible fix: after downloading a page, drop it from PageDataManager's cache, and decide what happens to edits of that page that are not saved yet.
- Dominant language
- Kotlin
- Stars
- 269
- Forks
- 44
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 22
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Ethran/notable
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
[AI] Line tool saves raw pen pressure (clamped to full pressure)Possibly taken @kal-kaliper claimed this 1 day ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
Editor burger menuOpenbug
Difficulty 3/5 1-2 days Newbie friendliness 55/100
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
Maintainers usually reply within 1 day
-
[Feature Suggestion] Independent Zoom Controls: Decouple Zoom-In from Zoom-Out (with 1.0x Snap)Open
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Maintainers usually reply within 1 day
Similar issues
-
area:data-quality importer size:S
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
enorm-labs/event-junkie#5136 ·
Maintainers usually reply within 1 day
-
0. Needs triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 1 day
-
Type: Possible bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
spacecowboy/Feeder#1318 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
wangzan101/Mika#644 ·
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
commons-app/apps-android-commons#7341 ·
Maintainers usually reply within 1 day