Notable and Onyx gestures interference

Open
  • Is something wrong?
#387 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
30/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Active
Tech stack
android, kotlin
Domain
mobile-dev

Research direction

Start by reading the Onyx SDK abstraction layer mentioned in the issue and identify whether it exposes a way to disable the system screenshot gesture. The issue also raises a separate close-button idea, so clarify which behavior is in scope before starting. Done should mean the chosen behavior is specified and works without requiring device-specific knowledge.

Written by the indexing model from the issue text.

Description

Enable it by default on Onyx devices.

I will say still no. We could present the option on the welcome screen, with explanation. There is already note about freezing. But this should be done in separate PR.

Add a close button to the top bar, similar to how reMarkable does it. This way, even when navigation gestures are enabled on Onyx devices, there’s still an obvious way to exit the app.

I have nothing against such button, we could add it on the top right on the library view.

The reason why three finger gestures don't work is system gesture to take a screenshot. Now onyx published source code for the sdk, maybe there is something that could allow to turn of only this gesture. The sdk is only a abstraction layer, so we don't need to know what device we are working with.

Originally posted by @Ethran in https://github.com/Ethran/notable/issues/327#issuecomment-5856566367

Dominant language
Kotlin
Stars
269
Forks
44
Avg merge
1d 17h
Merged PRs (30d)
22

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Ethran/notable

All issues in Ethran/notable

Similar issues

More Kotlin issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.