Undoing `-s` flagged command does not move the selection back.

Open
#2,299 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
game-dev

Research direction

Reproduce the issue with a selection, //move -s 10 up, and //undo, then trace the undo handling for the //move command and its selection shift. Done means undoing the command restores both the blocks and the selection to their previous locations.

Written by the indexing model from the issue text.

Description

status:accepted type:tech-debt
WorldEdit Version

7.2.14-SNAPSHOT

Platform Version

Bukkit-Official

Confirmations
  • I am using the most recent Minecraft release.
  • I am using a version of WorldEdit compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.
  • I am NOT using a hybrid server, e.g. a server that combines Bukkit and Forge. Examples include Arclight, Mohist, and Cardboard.
  • I am NOT using a fork of WorldEdit, such as FastAsyncWorldEdit (FAWE) or AsyncWorldEdit (AWE)
Bug Description

When using a command with a -s flag which shifts the selection to the new location (for example //move and then undoing the command, the selection is left in the new place.

Expected Behavior

When undoing such a command the selection should be moved back to the previous location. (I think at least, let me know if you disagree)

Reproduction Steps

Make a selection of some blocks
Run //move -s 10 up
Run //undo
Witness the Selection staying at the new location.

Anything Else?

Not sure if this is worth fixing. This would require saving locations and I have no idea how undo works internally atm. It is not a huge problem so the devs can decide if this is worth it.

Dominant language
Java
Stars
3.5k
Forks
981
Avg merge
2d 15h
Merged PRs (30d)
11

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from EngineHub/WorldEdit

All issues in EngineHub/WorldEdit

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.