[`//stack`] Stack Selection

Open
#3,038 5 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
62/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
java
Domain
cli

Research direction

Start by reading the //stack command implementation and its flag parsing, then check the command's documentation and tests for the current -s behavior. Determine whether that behavior is intentional before choosing whether to change it or add a distinct flag. Done means the requested selection includes the original and every pasted instance, the behavior is covered by tests, and the flags are documented.

Written by the indexing model from the issue text.

Description

status:accepted type:feature-request
The Problem

According to the docs, there is currently no -s flag on the //stack command to also stack the selection.

There is actually an undocumented effect of -s to //stack, though not what I would expect. Currently specifying -s leads to a selection around the last pasted instance of the stack.
What I would expect is for the selection to include the original and all pasted instances.

Use case: Currently, stacking in two directions requires two commands and adjusting the selection inbetween. This feature would make the middle step obsolete.

//stack 3 east
[Adjust selection, could be replaced by -s]
//stack 3 north
A Solution
  • If current -s behaviour is unintentional: Change the flag to the behaviour described above.
  • If current -s behaviour is intentional: Add a new flag that has the behaviour described above (e.g. -ss, if duplicate letters are no problem, although I suspect they are).

In both cases, the flags should be added to the documentation.

Alternatives

No response

Anything Else?

No response

Dominant language
Java
Stars
3.5k
Forks
981
Avg merge
2d 15h
Merged PRs (30d)
11

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from EngineHub/WorldEdit

All issues in EngineHub/WorldEdit

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.