quest: SessionBridge exposes no frame tap or side-channel send for the social facade

Closed
  • Is something wrong?
#236 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

A pull request for this has already been merged.

  • #348 by @thesprockee — merged

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp
Domain
networking

Research direction

Start with SessionBridge::BuildRequest and the Config struct in src/quest/net/session_bridge.{h,cpp}, then read the decorators in src/quest/integration/tapped_transports.* and integrated_bridge.. The work is to add a frame tap and a side-channel send to SessionBridge::Config, so the social facade no longer needs its own bridge. Done means the integration uses those hooks, the duplicated BuildRequest logic is gone, and integrated_bridge. is deleted.

Written by the indexing model from the issue text.

Description

backlog

Found while integrating the Quest packages (#158, branch claude-quest-integration).

quest_net::SessionBridge (src/quest/net/session_bridge.{h,cpp}, #226) builds its loopback server, router and remote transport privately. The social facade needs (1) every frame the bridge relays, in both directions (quest_social::ObserveFrames), (2) the moment the service accepts the login (quest_social::SetLocalAccount), (3) a way to send a request on the login session (SocialParty::SetSender). None is reachable from outside, so the integration composes the same parts itself: src/quest/integration/integrated_bridge.{h,cpp} with decorators in tapped_transports.*. It duplicates SessionBridge::BuildRequest (the auth route selection), which can drift.

Fix direction: give SessionBridge::Config a frame tap and a side-channel send, then delete integrated_bridge.*.

Dominant language
C++
Stars
2
Forks
5
Avg merge
4h 46m
Merged PRs (30d)
941

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from EchoTools/nevr-runtime

All issues in EchoTools/nevr-runtime

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.