Extraneous quote in include completion

Open Beginner friendly
#80 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
cpp, vscode

Research direction

Start by locating the include completion implementation and its tests in the repository; the issue does not name specific files. Check how the completion handles an opening quote when VS Code has already inserted the matching closing quote. Reproduce by accepting an include completion in VS Code and confirm the accepted text has no extra quote.

Written by the indexing model from the issue text.

Description

bug
Version

extension & server 0.0.20

Editor

vscode 1.145.2

Operating system

Debian forky/sid (Linux x64 7.1.12+deb14-amd64)

Build system

xmake

What happened

Extraneous quote found in the include completion. mcppls assumes that user didn't type the terminating quote, but in vscode, the editor automatically adds the quote to pair the opening quote.

Completion:
Image

Accepting the completion:
Image

Not tested on other IDEs.
No diagnostic bundle provided, this is an obvious bug.

What you expected

Remove the extraneous quote.

Diagnostic bundle
  • I attached the diagnostic bundle
Diagnostic report (only if there is no bundle)

Steps to reproduce

No response

Dominant language
C++
Stars
25
Forks
2
Avg merge
21h 5m
Merged PRs (30d)
13

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Sunrisepeak/mcpp-language-server

All issues in Sunrisepeak/mcpp-language-server

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.