No live-server confirmation that #117's unregister fix reaches BroadcasterUnlisten at runtime

Open
  • Is something wrong?
#121 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
55/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Active
Tech stack
c
Domain
testing-qa

Research direction

Review the fix in #117 and the related code in gameserver.cpp around lines 944 and 1125. Build and run the dedicated server with Debug logging enabled (requires owner approval). Capture the new owner-recorded log line and the 'Unregistered 15 broadcaster callbacks' message, and verify no 'callback registry reached from thread' warning appears.

Written by the indexing model from the issue text.

Description

Found during retroactive Opus review of c19f472 (fix for #117).

The fix (restoring broadcasterOwner recording so UnregisterBroadcasterCallbacks actually reaches EchoVR::BroadcasterUnlisten) is verified statically — history, call-path tracing, thread-safety analysis, and mutation-tested unit tests all confirm it's correct. But AGENTS.md requires a system test after any runtime commit, and this repo's logging rule 6 requires a real record from a real run, not just a clean build/test.

This fix makes 15 real BroadcasterUnlisten calls on every unregister where none happened before (the behavior was live for about a day between ba6b5f0 landing 2026-09-27 and 033b303 dropping it 2026-09-28, so there's precedent it worked before). Needs a dedicated-server run with Debug logging enabled, capturing:

  • the new owner-recorded log line (gameserver.cpp:944, currently Debug)
  • "Unregistered 15 broadcaster callbacks" (gameserver.cpp:1125, currently Debug)
  • no "callback registry reached from thread" warning

Launching a server for this needs the owner's go-ahead — not done as part of this review. Related: #45/#46 are also blocked on a live server run.

Dominant language
C++
Stars
2
Forks
5
Avg merge
4h 46m
Merged PRs (30d)
941

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from EchoTools/nevr-runtime

All issues in EchoTools/nevr-runtime

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.