`/price/:assetA/:assetB/history` turns a bad `limit` into a 500 and an unknown pair into an empty 200
Maintainers usually reply within 3 days
@I-frenzy is already working on this.
Since Nov 20, 2026.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 80/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- openapi, postgresql, typescript
Research direction
Read the history handler in src/api/rest.ts (lines 305–376), then inspect findPair and parseLimit in src/api/rest.ts and src/pagination.ts. Check the route tests in tests/rest-route.test.ts and src/__tests__/priceHistoryNetwork.test.ts first. Update openapi.yaml and regenerate the generated files; done means invalid limits return 400, unwatched pairs return 404, valid aliases resolve, and the existing response shape is preserved.
Written by the indexing model from the issue text.
Description
Background
In src/api/rest.ts, the history handler parses limit like this (line 316):
const limit = Math.min(parseInt(req.query.limit ?? String(HISTORY_DEFAULT_LIMIT), 10), HISTORY_MAX_LIMIT)
?limit=abc gives NaN, and ?limit=-5 gives -5. Both are passed to Postgres as the LIMIT and the request fails with a 500. Every other paged route uses parseLimit from src/pagination.ts, which answers a non-number with a 400 and clamps the rest.
The same handler builds the pair key from the raw path (line 317, makePairKey(assetA, assetB)), while /price/:assetA/:assetB in the same file resolves the pair with findPair (line 222) and answers 404 unwatched_pair for a pair it does not watch. So /price/xlm/usdc/history, /price/native/USDC/history or a pair that does not exist all return 200 with an empty buckets list. An integrator cannot tell "no data yet" from "you spelled it wrong".
The window check also runs after the pair key and decimal work; it should be the first thing rejected.
What to build
- Parse
limitwithparseLimit; a non-integer is a 400 with codeinvalid_parameter. - Resolve the pair with
findPair, as the sibling routes do, and answer404 unwatched_pairwhen it is not watched on that network. Query with the resolvedpair.pairKey. - Keep the response shape and the gap declaration unchanged for a valid request.
- Update
openapi.yamlfor the 400 and 404 and regenerate the generated files.
Where to look
src/api/rest.tslines 305 to 376 andfindPairat line 50src/pagination.tsparseLimittests/rest-route.test.ts,src/__tests__/priceHistoryNetwork.test.ts
Done when
-
limit=abcreturns 400, andlimit=-5andlimit=999999are clamped; none reaches Postgres as an invalid value - An unwatched pair returns
404 unwatched_pair; a lower-case ornativespelling of a watched pair returns its data - A valid request returns the same body as before
- Generated files are regenerated and
npm testpasses
Drips Wave · Complexity: Easy · 100 points
Repo: Divinity-Labs/Lens. Install with npm ci, typecheck with npx tsc --noEmit, test with npm test. Tests are vitest. Do not run jest: it reports zero tests and proves nothing.
You cannot reach the production service. Prove your change with local tests and fixtures. Mock the database (pgPool, prisma) the way the existing tests in src/__tests__/ and tests/ do.
Generated files are checked byte for byte by CI. If you add or change a route, edit openapi.yaml by hand and then regenerate the generated files and commit them: npm run openapi:gen (writes openapi.json and the README sections), npm run client:gen (the TypeScript client schema) and, if you touched the GraphQL schema, npm run graphql:schema:gen (writes schema.graphql). The full list is in the scripts section of package.json; also read CONTRIBUTING.md. If a check fails and the diff looks empty, it is line endings: commit with LF.
Prices are high-precision decimals. Do not add a new place where a price or amount goes through parseFloat, Number() or ::float before it reaches the caller.
MCP tools must return exactly the fields the matching REST route returns (tests/mcp-lens.test.ts asserts equality), and the MCP tool modules must not import the database driver directly. Reads are injected.
Do not remove or loosen an existing API-key scope, CORS rule or rate limit, and do not replace src/app.ts wholesale. Past pull requests did both by accident.
Do not weaken a test to make it pass. No real user data, wallet addresses of real users, keys, tokens or connection strings in code, tests or fixtures. Never shorten a Stellar address or contract id; copy it in full from the file that defines it.
Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk
- Dominant language
- TypeScript
- Stars
- 4
- Forks
- 71
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 24
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Divinity-Labs/Lens
-
area:database difficulty:easy help wanted points:100 Stellar Wave
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Divinity-Labs/Lens#688 · 1 comment ·
Maintainers usually reply within 3 days
-
area:reliability difficulty:easy help wanted points:100 Stellar Wave
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Divinity-Labs/Lens#663 · 1 comment ·
Maintainers usually reply within 3 days
-
`/status?network=mainnet` is rate limited although `/status` is exemptPossibly taken @Joyful12-tech claimed this 1 day ago. Openarea:reliability difficulty:easy help wanted points:100 Stellar Wave
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Divinity-Labs/Lens#662 ·
Maintainers usually reply within 3 days
-
area:ingest difficulty:easy help wanted points:100 Stellar Wave
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Divinity-Labs/Lens#633 ·
Maintainers usually reply within 3 days
-
Webhook retries have no jitter, so failures synchronisePossibly taken @Richard-tobi claimed this 35 days ago. Openarea:reliability difficulty:easy help wanted points:100 Stellar Wave
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Divinity-Labs/Lens#341 · 2 comments · 1 assignee ·
Maintainers usually reply within 3 days
All issues in Divinity-Labs/Lens
Similar issues
-
[功能请求] 设置选项语言调整Open功能请求
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
antithesishq/bombadil#473 ·
Maintainers usually reply within 2 days
-
The structured output reference promises null results for refusals that carry validation detailsOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
mattermost/mattermost-mobile#10358 ·
Maintainers usually reply within 1 day
-
ready-for-agent
Difficulty 1/5 Under an hour Newbie friendliness 86/100
LucasSantana-Dev/Lucky#3257 ·
Maintainers usually reply within 1 day