Phoenix price points are keyed on the wall clock, so a replay is stored twice

Open Beginner friendly
#633 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 3 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
postgresql, typescript

Research direction

Read src/ingest/venues/phoenix.ts around lines 426–470, compare the identity pattern in src/ingest/venues/soroswap.ts around line 392, and check upsertPricePoints in src/db.ts. Add or update tests in src/__tests__/phoenixIngester.test.ts and src/__tests__/pricePointIdentity.test.ts to verify stable ids for identical pool reads, different ids for changed reserves, and that replaying a batch does not add a row. Run the relevant Vitest tests; done means all listed identity and replay cases pass without clock or random values in the id.

Written by the indexing model from the issue text.

Description

area:ingest difficulty:easy help wanted points:100 Stellar Wave
Background

Issue #237 set a rule for rows that have no trade id: the row's identity must
come from the state that was read, never from the clock. The Soroswap adapter
states it in a comment: "Must never be Date.now()/random." The Horizon AMM
keys its snapshot on (pool, last_modified_ledger).

derivePhoenixPricePoints in src/ingest/venues/phoenix.ts (line 467) breaks
the rule:

eventId: `phoenix-${raw.poolAddress}-${Date.now()}`,

Every call makes a new id. A retried batch, or a second instance reading the
same pool, inserts the same observation again. The function is also documented
as "Pure", and it is not.

What to build
  • Derive the id from the pool state: the pool address and the two reserves,
    as Soroswap does (soroswap-${pool}-${reserveA}-${reserveB}).
  • Make sure the id does not depend on which way round the pool stores the
    pair. The function swaps a and b for a reversed pool; build the id from
    the raw reserves before the swap, or from a fixed order.
  • Check what this does to an unchanged pool: identical reserves now produce
    the same id, so the second write is skipped as a duplicate. Say in the PR
    whether that is the wanted behaviour and what it means for freshness.
Where to look
  • src/ingest/venues/phoenix.ts lines 426–470
  • src/ingest/venues/soroswap.ts line 392 for the pattern
  • src/db.ts upsertPricePoints for how eventId becomes the row id
  • src/__tests__/phoenixIngester.test.ts, src/__tests__/pricePointIdentity.test.ts
Done when
  • Two calls with the same pool read return the same eventId
  • Two calls with different reserves return different ids
  • No Date.now() or random value is used to build the id
  • A test proves a replayed batch does not create a second row

Drips Wave · Complexity: Easy · 100 points


Repo: Divinity-Labs/Lens. Install with npm ci, typecheck with
npx tsc --noEmit, test with npm test. Tests are vitest, not jest
(running jest reports zero tests and proves nothing).

You cannot reach the production deployment. Everything must be proven with
local tests and fixtures. Do not write a test that needs the live network.

No floating point in new price or amount maths. Prices are stored as
Decimal(36, 18) and amounts as Decimal(36, 7). Do sums in SQL numeric, in
bigint, or on decimal strings. If you must touch existing float code, do not
add more of it.

The price convention is fixed: a stored price means units of assetB per
one unit of assetA, in the order the pair is configured. Every adapter must
follow it.

Generated files are checked byte for byte by CI (the OpenAPI spec, the
README sections, the GraphQL schema file, the TypeScript client schema, and the
Prisma migration baseline). If you change a route, the GraphQL schema or
prisma/schema.prisma, regenerate the generated files and commit them. The
commands are in the scripts section of package.json (openapi:gen,
readme:gen, graphql:schema:gen, client:gen) and in CONTRIBUTING.md. A
schema change also needs a migration and a regenerated baseline: see
docs/database-migrations.md. The database is migrated with
prisma migrate deploy, never db push.

Never shorten or invent a contract id or issuer address. Copy it in full
from the repo. If a venue's id is not in the repo, read it from the venue's
official docs and cite the source in the PR.

No personal data and no secrets in code, fixtures, logs or the PR. A
fixture recorded from a public API must not contain an API key.

Do not weaken a test to make it pass. If an existing test encodes the bug
you are fixing, change the test and say so in the PR.



Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Dominant language
TypeScript
Stars
4
Forks
71
Avg merge
2d 6h
Merged PRs (30d)
24

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Divinity-Labs/Lens

All issues in Divinity-Labs/Lens

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.