Restructure the data collection group tags to use the rsyncer table

Open
#792 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Quiet
Tech stack
python
Domain
backend

Research direction

Resolve #791 first, then trace how data collection group tags, fractions, metadata, and the rsyncer table are represented. Pay particular attention to tomography multigrid and EPU's Images-Disc2 behavior; done means consistent DCG registrations without relying on the current file-path-based tags.

Written by the indexing model from the issue text.

Description

For tomography multigrid the data collection group tags don't match between the fractions and metadata.
The fractions are in the form base/Supervisor_SampleX while the fractions are base/visit/Supervisor/SampleX so underscope vs slash causes issues.

This relates to a wider problem where the data collection group tag should be replaced with an rsyncer group to ensure the dcg registrations are consistent. This would make it clearer how fractions and metadata relate as it would avoid using file paths in the current way, but it requires some major code restructuring.

EPU sessions present some problems, in particular with the Images-Disc2 behaviour where the metadata and fractions are related but need to become separate dcgs.

#791 needs fixing before this can be attempted

Dominant language
Python
Stars
2
Forks
1
Avg merge
1d 12h
Merged PRs (30d)
22

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DiamondLightSource/python-murfey

All issues in DiamondLightSource/python-murfey

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.